Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: fix canParse false value when v8 optimizes #48817

Closed
wants to merge 1 commit into from
Closed

url: fix canParse false value when v8 optimizes #48817

wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jul 17, 2023 •
edited
Loading

Fixes #48816

I requested fast-track to include this change with the currently pending Node 18 release (which includes URL.canParse as well. cc @danielleadams

cc @nodejs/url

@anonrig anonrig requested a review from KhafraDev July 17, 2023 17:42
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 17, 2023
This was referenced Jul 17, 2023
Closed
Merged
Closed
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Jul 17, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52818/

tniessen
tniessen reviewed Jul 17, 2023
View reviewed changes
test/parallel/test-whatwg-url-canparse.js
@@ -19,3 +19,11 @@ const { canParse } = internalBinding('url');
// It should not throw when called without a base string
assert.strictEqual(URL.canParse('https://example.org'), true);
assert.strictEqual(canParse('https://example.org'), true);

// This for-loop is used to test V8 Fast API optimizations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// This for-loop is used to test V8 Fast API optimizations
// This for-loop is used to test V8 Fast API optimizations.

@anonrig
Copy link
Member Author

anonrig commented Jul 17, 2023

@nodejs/build it seems windows-fanned build is failing. is there an outage?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52825/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52826/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 18, 2023
@github-actions github-actions bot mentioned this pull request Jul 18, 2023
Open
26 tasks
danielleadams pushed a commit that referenced this pull request Jul 18, 2023
@anonrig @danielleadams
url: fix canParse false value when v8 optimizes
e0500d6 
PR-URL: #48817
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@danielleadams
Copy link
Contributor

Landed in e0500d6

@anonrig anonrig mentioned this pull request Jul 18, 2023
Merged
@danielleadams
Copy link
Contributor

@anonrig this will need a backport to v18.x-staging

@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 18, 2023
juanarbol pushed a commit that referenced this pull request Jul 18, 2023
@anonrig @juanarbol
url: fix canParse false value when v8 optimizes
07bfcc4 
PR-URL: #48817
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
This was referenced Jul 19, 2023
Open
Open
Open
Open
Open
Open
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@anonrig
url: fix canParse false value when v8 optimizes
b0347ff 
PR-URL: nodejs#48817
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@anonrig
url: fix canParse false value when v8 optimizes
355c44a 
PR-URL: nodejs#48817
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
url: fix canParse false value when v8 optimizes
386a593 
PR-URL: nodejs#48817
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
url: fix canParse false value when v8 optimizes
6803912 
PR-URL: nodejs#48817
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen left review comments

@KhafraDev KhafraDev KhafraDev approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lemire lemire lemire approved these changes

@Qard Qard Qard approved these changes

Assignees
No one assigned
Labels
backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL.canParse fails when stressed
8 participants
@anonrig @nodejs-github-bot @danielleadams @Qard @lemire @benjamingr @tniessen @KhafraDev