-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage drop in nightly runs #16129
Labels
test
Issues and PRs related to the tests.
Comments
Quite likely related to 5be4dfa#diff-b67911656ef5d18c4ae36cb6741b7965 |
And this PR #15450 Looks like n-api addons may not be running in nightly builds either: From https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1404-32/13016/console The before/after is as follows and addons seems to be mentioned but I'm not sure if that includes the n-api versions.
|
Ping @bcoe |
3 tasks
refack
added a commit
to refack/node
that referenced
this issue
Oct 12, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: nodejs#16132 Fixes: nodejs#16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin E. Coe <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this issue
Oct 15, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: nodejs/node#16132 Fixes: nodejs/node#16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin E. Coe <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this issue
Oct 18, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: #16132 Fixes: #16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin E. Coe <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this issue
Oct 18, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: #16132 Fixes: #16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin E. Coe <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From the latest runs the c coverage has dropped 6.5%. Seems like it may be that the n-api tests are no longer running as one thing I noticed is that the coverage for node-api.cc was 0.
The text was updated successfully, but these errors were encountered: