Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage drop in nightly runs #16129

Closed
mhdawson opened this issue Oct 10, 2017 · 4 comments · Fixed by #16132
Closed

Coverage drop in nightly runs #16129

mhdawson opened this issue Oct 10, 2017 · 4 comments · Fixed by #16132
Labels
test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

  • Version: master
  • Platform: all
  • Subsystem: test

From the latest runs the c coverage has dropped 6.5%. Seems like it may be that the n-api tests are no longer running as one thing I noticed is that the coverage for node-api.cc was 0.

@mhdawson
Copy link
Member Author

Quite likely related to 5be4dfa#diff-b67911656ef5d18c4ae36cb6741b7965

@mhdawson
Copy link
Member Author

And this PR #15450

Looks like n-api addons may not be running in nightly builds either:

From https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1404-32/13016/console

The before/after is as follows and addons seems to be mentioned but I'm not sure if that includes the n-api versions.


After
/usr/bin/python tools/test.py -p tap --logfile test.tap --mode=release --flaky-tests=dontcare \
		 addons doctool message parallel pseudo-tty sequential

Before
/usr/bin/python tools/test.py -j 2 -p tap --logfile test.tap \
		--mode=release --flaky-tests=dontcare \
		 async-hooks default known_issues

@BridgeAR
Copy link
Member

Ping @bcoe

@mhdawson
Copy link
Member Author

@BridgeAR thanks for looping in @bcoe I suspect he'll be able to quickly see if there is an issue in the change of if there is some update I need to make in the coverage job.

@mscdex mscdex added the test Issues and PRs related to the tests. label Oct 10, 2017
refack added a commit to refack/node that referenced this issue Oct 12, 2017
suites dropped during the last commit by a typo
restore $(CI_JS_SUITES) to test-ci-js
restore $(CI_NATIVE_SUITES) for `test-ci`
and var assignment tweak

PR-URL: nodejs#16132
Fixes: nodejs#16129
Fixes: nodejs/build#910
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin E. Coe <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this issue Oct 15, 2017
suites dropped during the last commit by a typo
restore $(CI_JS_SUITES) to test-ci-js
restore $(CI_NATIVE_SUITES) for `test-ci`
and var assignment tweak

PR-URL: nodejs/node#16132
Fixes: nodejs/node#16129
Fixes: nodejs/build#910
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin E. Coe <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this issue Oct 18, 2017
suites dropped during the last commit by a typo
restore $(CI_JS_SUITES) to test-ci-js
restore $(CI_NATIVE_SUITES) for `test-ci`
and var assignment tweak

PR-URL: #16132
Fixes: #16129
Fixes: nodejs/build#910
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin E. Coe <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this issue Oct 18, 2017
suites dropped during the last commit by a typo
restore $(CI_JS_SUITES) to test-ci-js
restore $(CI_NATIVE_SUITES) for `test-ci`
and var assignment tweak

PR-URL: #16132
Fixes: #16129
Fixes: nodejs/build#910
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin E. Coe <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants