-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: make test-ci-js
got broke and we didn't notice
#910
Comments
citgm-smoker uses Junit not TAP. |
3 tasks
@jbergstroem did some work on getting transforming the node test suite to output Junit ... the junit plugin for Jenkins is waaaaay better |
refack
added a commit
to refack/node
that referenced
this issue
Oct 12, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: nodejs#16132 Fixes: nodejs#16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin E. Coe <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this issue
Oct 15, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: nodejs/node#16132 Fixes: nodejs/node#16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin E. Coe <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this issue
Oct 18, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: #16132 Fixes: #16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin E. Coe <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this issue
Oct 18, 2017
suites dropped during the last commit by a typo restore $(CI_JS_SUITES) to test-ci-js restore $(CI_NATIVE_SUITES) for `test-ci` and var assignment tweak PR-URL: #16132 Fixes: #16129 Fixes: nodejs/build#910 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin E. Coe <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In nodejs/node@5be4dfa#diff-b67911656ef5d18c4ae36cb6741b7965R362
the make target
test-ci-js
lost$(CI_JS_SUITES)
so it only tested async-hooks and known_issues (70 tests).AFAICT it's only used by
node-test-binary-arm
, but that made me think - can we merge all the TAP reports and put upstream (similar tocitgm-smoker
)?Fix PR: nodejs/node#16132
results from one subset
The text was updated successfully, but these errors were encountered: