Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: make test-ci-js got broke and we didn't notice #910

Closed
refack opened this issue Oct 10, 2017 · 2 comments · Fixed by nodejs/node#16132
Closed

CI: make test-ci-js got broke and we didn't notice #910

refack opened this issue Oct 10, 2017 · 2 comments · Fixed by nodejs/node#16132

Comments

@refack
Copy link
Contributor

refack commented Oct 10, 2017

In nodejs/node@5be4dfa#diff-b67911656ef5d18c4ae36cb6741b7965R362
the make target test-ci-js lost $(CI_JS_SUITES) so it only tested async-hooks and known_issues (70 tests).

AFAICT it's only used by node-test-binary-arm, but that made me think - can we merge all the TAP reports and put upstream (similar to citgm-smoker)?

Fix PR: nodejs/node#16132

results from one subset
+ make test-ci-js
# Clean up any leftover processes but don't error if found.
ps awwx | grep Release/node | grep -v grep | cat
python tools/test.py -j 1 -p tap --logfile test.tap \
	--mode=release --flaky-tests=dontcare \
	--run=1,7 async-hooks known_issues
TAP version 13
1..10
ok 1 async-hooks/test-connection.ssl
  ---
  duration_ms: 2.527
  ...
ok 2 async-hooks/test-embedder.api.async-resource.improper-order
  ---
  duration_ms: 1.525
  ...
ok 3 async-hooks/test-fseventwrap
  ---
  duration_ms: 0.823
  ...
ok 4 async-hooks/test-graph.intervals
  ---
  duration_ms: 0.924
  ...
ok 5 async-hooks/test-graph.timeouts
  ---
  duration_ms: 0.823
  ...
ok 6 async-hooks/test-pipeconnectwrap
  ---
  duration_ms: 0.923
  ...
ok 7 async-hooks/test-signalwrap
  ---
  duration_ms: 1.24
  ...
ok 8 async-hooks/test-ttywrap.writestream # skip no valid writable TTY available
  ---
  duration_ms: 0.923
  ...
ok 9 known_issues/test-http-path-contains-unicode
  ---
  duration_ms: 1.24
  ...
ok 10 known_issues/test-vm-attributes-property-not-on-sandbox
  ---
  duration_ms: 0.823
  ...
# Clean up any leftover processes, error if found.
ps awwx | grep Release/node | grep -v grep | cat
[node-test-binary-arm] $ /bin/sh -xe /tmp/hudson5021250183769314254.sh
+ set +x
Tue 10 Oct 16:27:15 UTC 2017
+ pgrep node
+ true
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Saving reports...
Processing '/var/lib/jenkins/jobs/node-test-binary-arm/configurations/axis-RUN_SUBSET/1/axis-label/pi3-raspbian-jessie/builds/10769/tap-master-files/test.tap'
Parsing TAP test result [/var/lib/jenkins/jobs/node-test-binary-arm/configurations/axis-RUN_SUBSET/1/axis-label/pi3-raspbian-jessie/builds/10769/tap-master-files/test.tap].
TAP Reports Processing: FINISH
Checking ^not ok
Notifying upstream projects of job completion
Finished: SUCCESS
@gibfahn
Copy link
Member

gibfahn commented Oct 10, 2017

can we merge all the TAP reports and put upstream (similar to citgm-smoker)?

#802

citgm-smoker uses Junit not TAP.

@MylesBorins
Copy link
Contributor

@jbergstroem did some work on getting transforming the node test suite to output Junit ... the junit plugin for Jenkins is waaaaay better

refack added a commit to refack/node that referenced this issue Oct 12, 2017
suites dropped during the last commit by a typo
restore $(CI_JS_SUITES) to test-ci-js
restore $(CI_NATIVE_SUITES) for `test-ci`
and var assignment tweak

PR-URL: nodejs#16132
Fixes: nodejs#16129
Fixes: nodejs/build#910
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin E. Coe <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this issue Oct 15, 2017
suites dropped during the last commit by a typo
restore $(CI_JS_SUITES) to test-ci-js
restore $(CI_NATIVE_SUITES) for `test-ci`
and var assignment tweak

PR-URL: nodejs/node#16132
Fixes: nodejs/node#16129
Fixes: nodejs/build#910
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin E. Coe <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Oct 18, 2017
suites dropped during the last commit by a typo
restore $(CI_JS_SUITES) to test-ci-js
restore $(CI_NATIVE_SUITES) for `test-ci`
and var assignment tweak

PR-URL: #16132
Fixes: #16129
Fixes: nodejs/build#910
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin E. Coe <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Oct 18, 2017
suites dropped during the last commit by a typo
restore $(CI_JS_SUITES) to test-ci-js
restore $(CI_NATIVE_SUITES) for `test-ci`
and var assignment tweak

PR-URL: #16132
Fixes: #16129
Fixes: nodejs/build#910
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin E. Coe <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants