Release proposal: 1.8.0 #1436
Comments
brendanashworth
added
the
meta
|
I'm very keen on landing #1429 beforehand. At least, part of it that fixes building against shared libraries. One added action: switch default branch in jenkins job description. |
|
re release tooling - I don't think there's anything I need to do, there are some defaults but they are just defaults and shouldn't impact builds or tests. re commit log, run re version, even though it's only the process.nextTick() changes that are forcing this, the bump in openssl fits nicely under there because of the potential for changes in user experience (even though in theory it shouldn't be noticable). timing of this release is up to you but depending on the progress towards merging v8, we may see a 1.8.1 before we go 2.0.0 given the things that need to line up for that to be ready to go so perhaps we need a transitional git process that gives us the freedom to cut a 1.8.1 if 2.0.0 is taking longer than we expect? your call but keep that in mind. |
|
I would like to land #1412 . before v2.0. |
|
published changelog-maker v1.3.2 to account for that |
|
thanks for the changelog-maker tip! re: timing and a potential 1.8.1: I was thinking about that a bit. I don't think the steps above would preclude us from making new releases on the v1.x line on the road up to v2.0.0 – at least, not for any technical reason. Patches comprising v1.8.1 would land in v1.x and be merged up to master. That said, I agree it'd be best to minimize the amount of time we're doing that for because past experience has shown that that can quickly get out of hand. A note about the
That way when the nightly build kicks off we can treat that as the first release candidate for io.js v2.0.0. Should we "fix" The alternative is to drop the following commits from master and then fast-forward merging v1.x to master, but then |
|
I'm going to opt out of making suggestions on this one, if @bnoordhuis has time then he should provide input since he started the work on I think at this stage my vote would be for continuing to publish nightlies off |
Not so sure about this. There's commits from the past that haven't been in a release between, which will just be confusing (even though they are mostly docs commits iirc). I'd think it would make more sense to push over master and cherry-pick anything that isn't in the new master, as applicable. |
|
I have to say, it all sounds rather complicated. Next is essentially v1.x + V8 4.2 + semver-major patches. Master doesn't contain anything interesting. Why not force-push next:master (or if force-pushing sets off alarm bells: delete master and rename or branch from next) and merge v1.x into next/master after every release? |
I think the plan is to backport patches only for LTS, and not do how node is currently doing it? |
|
In any case, if we don't care about the commits master has that v1.x doesn't, dropping them is definitely an option and simplifies things a bit. Didn't want to assume we were on with dropping that data, though :) I'll revise in a bit.
|
Right, I forgot. That's fine then, no up-merges. |
|
How about land #1242 into 1.8.0? |
Not 100% sure of this. We should do a diff and check what v1.x is missing, then evaluate. :) |
|
@Fishrock123 those commits are linked above.
|
|
I think the contribution policy stuff all exists in better form in v1.x today. (That is: e7dec60, cafac11, 7ee5c4e, 8c60aaa, 051dc54, & f60abb0) /cc @mikeal though. We already have the TC meetings in v1.x (2c7847b & 3cb5f3d) That leaves 3 commits (excluding merges and the 0.13.0 version bump):
The last one appears to have landed in v1.x at cca8de6. (No PR metadata, couldn't find it. EDIT: #834) That leaves just these two:
Shall I open a PR to get these into v1.x? Edit: the stream change is easy. the vcbuild.bat change has some conflicts, not too bad though. |
|
Sorry for the lack of metadata. It was in a batch of commits I cherry picked over from joyent/node. |
|
Okay, we're going to reset master to 3a9754a, that way v1.x can fast-forward merge onto it. |
|
Are we in a |
|
Re:
During the steady state, During the run up state, |
|
@silverwind Yep, that sounds good to me, especially since we're coming up on semver-major so we can remove the hack :) |
|
Ok, assuming there are no issues raised, I'll plan on cutting this release tomorrow (4/17) in the late AM, PST. #1363, #1444, #1242 will go in, assuming they land before then. #1412 might be a good candidate to land on master after the merge, as @Fishrock123 noted in that PR. |
|
I will also attempt to make a doc-deprecation PR for util.is* real soon, we'll see. |
|
Just putting down a marker here that I would very much like if |
|
@othiym23 sure, I'm around to do a review if your PR it. :) |
|
Here I wrote a note about a crypto performance for OpenSSL-1.0.2a on iojs v1.8.0. Owing to AVX2 support, the benchmark shows that iojs-v1.8.0 has achieved about 140% - 160% performance gain on Haswell for RSA, SHA256 and AES-GCM operations compared with v1.7.1.
|
|
Aaah, really! That's great then! @chrisdickinson we are good |
|
Thank you, @shigeki |
|
Proper ABI versioning <3 |
|
OK, 1.8.1 it is then, no 1.8.0 release and the NODE_MODULE_VERSION rolled back so no ABI breakage. I'm +0 on removing the 1.8.0 tag--one benefit would be that you could write the changelog as if 1.8.0 didn't even exist. |
|
(Edited comment, sorry email recipients) |
|
Sorry to everyone for confusion. It was my job to notice ABI compatibilities before upgrading. |
It says it shouldn't need to be recompiled? Did we not need the ABI bump? Honestly I still find it silly we can't do ABIs for minors. ¯_(ツ)_/¯ |
|
@shigeki @indutny this is great news! I'll redo the v1.8.1 PR so that OpenSSL remains in. And no need to apologize – thanks again for your hard work! @Fishrock123 We still have to revert the python env var change – cmd.exe treats its use in quotes at the bottom of vcbuild.bat as a string, not a command, and fails out due to that (as I understand it). @rvagg I'll delete the v1.8.0 tag. Once OSX works (and the v1.8.1 PR is updated & approved) we can cut the release.
|
|
It looks like everything passed except for pi1! I'm just excited about this release feeling anxious waiting. You're probably already aware of this, but it looks like the pi1 distro takes a really long to compile, orders of magnitude longer. Maybe the process would be more efficient separating the arm6 build? I have no idea how Jenkins works, but I own 3 raspi's and use iojs on them frequently :) Arm6 is a very special use case thou, I'd volunteer one of my pi's full time if that'd help at all? I also have no idea what I'm talking about, so if something else is happening behind the scenes then nm |
|
@chrisdickinson last nightly worked in all except for the windows machines: https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/154/ -> https://iojs.org/download/nightly/v1.8.1-nightly2015042077db7e168e/ We need that Windows vcbuild.bat fix in so we can get a fully successful nightly done. |
|
Ok. Going ahead with iojs v1.8.1 release build. (Sidenote: I think I might PR some "if this step goes wrong" bailout instructions into the releases doc.) |
|
Looks like windows is having trouble archiving the build artifact. However, the |
|
Holding off on promoting and signing until we figure out what's going on with Windows. |
|
OSX, Windows x64 msi, and CentOS look good! |
|
Announced on twitter. Thanks everyone! I'll leave this issue open for 24 hours and close if there have been no problems since. Will also merge the v1.8.1 changes into master. |
PR-URL: nodejs#53 Related: nodejs/node#1436 Signed-off-by: Hans Kristian Flaatten <[email protected]>
Notable Changes: * build: Support for building io.js as a static library (Marat Abdullin) #1341 * deps: upgrade openssl to 1.0.2a (Shigeki Ohtsu) #1389 * npm: Upgrade npm to 2.8.3. (Forrest L Norvell) #1448 * src: allow multiple arguments to be passed to process.nextTick (Trevor Norris) #1077 * module: the interaction of require('.') with NODE_PATH has been restored and deprecated. This functionality will be removed at a later point. (Roman Reiss) #1363
|
This can be closed now, great job |
|
Sorry to be such a pita, but... ¿aren't the armv6 missing for 1.8.1? PD: [OffTopic] Soon i will get my hands on a rpi2 and will probably stop whinning(noticing). |
|
I think they weren't promoted yet. @chrisdickinson? |
|
So he is who's meant to promote 'em... well, i think he's got way more important tasks to worry about right now (#1506 for iojs v2.0.0), so this might very well wait 'till 2.0.0 gets out the oven IMHO. Bonus: programmer_interrupted.png Edited: not displaying image due to size -@Fishrock123 |
|
Reopening until the armv6 build is out. I re-ran |
|
@chrisdickinson re-run the entire release build and ping me when you want to promote and I'll clean out everything but armv6 |
|
or re-run the release build and manually kill all of the non-armv6 builds in jenkins and you'll get the same effect without needing me |
|
OK! armv6 promoted, it should be good to go. Closing the issue now. Thanks all! |
As it stands, there are some commits on master that are not part of v1.x, and some commits in v1.x that are not part of a v1.x release. To remedy this, and get us onto the master branch in anticipation of a v2.0.0 release, I propose a v1.8.0 release, the final non-support-related release in the v1.x line.
the proposed plan
actions
(eugh, accidentally overwritten by changelog!)
outcomes
v2.xbranch. It will be cut once a v3.0.0 release is made to prevent having to constantly update it to match master.targets-mastermight be best?v1.xbranch.questions
The proposed changelog:
431673ebd1] - buffer: fast-case for empty string in byteLength (Jackson Tian) #144191943a99d5] - build: use %PYTHON% instead of python (Rod Vagg) #1444c7769d417b] - build: Expose xz compression level (Johan Bergström) #1428a530b2baf1] - build: fix error message in configure (Shigeki Ohtsu) #138992dfb794f9] - build: enable ssl support on arm64 (Shigeki Ohtsu) #13897de0dcde83] - deps: make node-gyp work with io.js (cjihrig) #9904870213f9e] - deps: upgrade npm to 2.8.3 (Forrest L Norvell)49bb7ded2c] - deps: fix git case sensitivity issue in npm (Chris Dickinson) #14564830b4bce8] - deps: add docs to upgrade openssl (Shigeki Ohtsu) #138911bec72c87] - deps: update asm files for openssl-1.0.2a (Shigeki Ohtsu) #138953924d8ebe] - deps: update asm Makefile for openssl-1.0.2a (Shigeki Ohtsu) #1389418e839456] - deps: update openssl.gyp/gypi for openssl-1.0.2a (Shigeki Ohtsu) #138902f12ab666] - deps: update opensslconf.h for 1.0.2a (Shigeki Ohtsu) #1389eb7a23595f] - deps: add x32 and arm64 support for opensslconf.h (Shigeki Ohtsu) #1389033a663127] - deps: replace all headers in openssl (Shigeki Ohtsu) #1389ae8831f240] - deps: backport openssl patch of alt cert chains 1 (Shigeki Ohtsu) #138971316c46d9] - deps: fix asm build error of openssl in x86_win32 (Shigeki Ohtsu) #1389d293a4f096] - deps: fix openssl assembly error on ia32 win32 (Fedor Indutny) #1389e4872d7405] - deps: upgrade openssl to 1.0.2a (Shigeki Ohtsu) #1389a1c9ef3142] - deps, build: add support older assembler (Shigeki Ohtsu) #138976f219c128] - doc: Document forced pushing with git (Johan Bergström) #142012e51d56c1] - doc: add Addon API WG (Rod Vagg) #12267956a13dad] - http: logically respect maxSockets (fengmk2) #12425b844e140b] - module: fix style (Roman Reiss) #14533ad82c335d] - (SEMVER-MINOR) module: handle NODE_PATH in require('.') (Roman Reiss) #1363cd60ff0328] - net: add fd into listen2 debug info (Jackson Tian) #144210e31ba56c] - (SEMVER-MINOR) node: allow multiple arguments passed to nextTick (Trevor Norris) #1077116c54692a] - openssl: fix keypress requirement in apps on win32 (Shigeki Ohtsu) #138962f5f4cec9] - src: remove duplicate byteLength from Buffer (Jackson Tian) #143851d0808c90] - stream: remove duplicated expression (Yazhong Liu) #1444deb9d23d7b] - test: fix error message check for openssl-1.0.2a (Shigeki Ohtsu) #1389ca8c9ec2c8] - win,node-gyp: optionally allow node.exe/iojs.exe to be renamed (Bert Belder) #1266cc @iojs/tc @iojs/collaborators
The text was updated successfully, but these errors were encountered: