Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove duplicate byteLength #1438

Closed
wants to merge 1 commit into from
Closed

src: remove duplicate byteLength #1438

wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

In commit 36a7795, the byteLength was added repeatedly.

@JacksonTian
src: remove duplicate byteLength
7bdbbec 
In commit 36a7795, the byteLength was added repeatedly.
@brendanashworth brendanashworth added the buffer Issues and PRs related to the buffer subsystem. label Apr 16, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Apr 16, 2015

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

@Fishrock123 Fishrock123 added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 16, 2015
cjihrig pushed a commit that referenced this pull request Apr 16, 2015
@JacksonTian @cjihrig
src: remove duplicate byteLength from Buffer
62f5f4c 
Commit 36a7795 introduced a duplicate Buffer byteLength property.

PR-URL: #1438
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@cjihrig
Copy link
Contributor

cjihrig commented Apr 16, 2015

Thanks! Landed in 62f5f4c.

@cjihrig cjihrig closed this Apr 16, 2015
@chrisdickinson chrisdickinson mentioned this pull request Apr 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JacksonTian @cjihrig @jbergstroem @Fishrock123 @brendanashworth