test: prepare tests for no-cond-assign ESLint rule

PR-URL: #41614 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Jan 24, 2022 · 9d99c24 · 9d99c24
1 parent 301a4f8
commit 9d99c24
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/test/parallel/test-child-process-flush-stdio.js b/test/parallel/test-child-process-flush-stdio.js
@@ -27,7 +27,7 @@ const spawnWithReadable = () => {
   }));
   p.stdout.on('readable', () => {
     let buf;
-    while (buf = p.stdout.read())
+    while ((buf = p.stdout.read()) !== null)
       buffer.push(buf);
   });
 };
diff --git a/test/parallel/test-net-server-max-connections.js b/test/parallel/test-net-server-max-connections.js
@@ -68,7 +68,7 @@ function makeConnection(index) {
       if (closes === N / 2) {
         let cb;
         console.error('calling wait callback.');
-        while (cb = waits.shift()) {
+        while ((cb = waits.shift()) !== undefined) {
           cb();
         }
         server.close();

diff --git a/test/parallel/test-stream-readable-object-multi-push-async.js b/test/parallel/test-stream-readable-object-multi-push-async.js
@@ -47,7 +47,7 @@ const BATCH = 10;
   readable.on('readable', () => {
     let data;
     console.log('readable emitted');
-    while (data = readable.read()) {
+    while ((data = readable.read()) !== null) {
       console.log(data);
     }
   });

diff --git a/test/parallel/test-stream-unshift-empty-chunk.js b/test/parallel/test-stream-unshift-empty-chunk.js
@@ -41,7 +41,7 @@ let readAll = false;
 const seen = [];
 r.on('readable', () => {
   let chunk;
-  while (chunk = r.read()) {
+  while ((chunk = r.read()) !== null) {
     seen.push(chunk.toString());
     // Simulate only reading a certain amount of the data,
     // and then putting the rest of the chunk back into the

diff --git a/test/parallel/test-zlib-brotli-flush.js b/test/parallel/test-zlib-brotli-flush.js
@@ -16,7 +16,7 @@ deflater.write(chunk, function() {
   deflater.flush(function() {
     const bufs = [];
     let buf;
-    while (buf = deflater.read())
+    while ((buf = deflater.read()) !== null)
       bufs.push(buf);
     actualFull = Buffer.concat(bufs);
   });

diff --git a/test/parallel/test-zlib-flush.js b/test/parallel/test-zlib-flush.js
@@ -23,7 +23,7 @@ deflater.write(chunk, function() {
     deflater.flush(function() {
       const bufs = [];
       let buf;
-      while (buf = deflater.read())
+      while ((buf = deflater.read()) !== null)
         bufs.push(buf);
       actualFull = Buffer.concat(bufs);
     });

diff --git a/test/parallel/test-zlib-params.js b/test/parallel/test-zlib-params.js
@@ -21,7 +21,7 @@ deflater.write(chunk1, function() {
     deflater.end(chunk2, function() {
       const bufs = [];
       let buf;
-      while (buf = deflater.read())
+      while ((buf = deflater.read()) !== null)
         bufs.push(buf);
       actual = Buffer.concat(bufs);
     });