repl: check for precise values rather than falsy in loops

This prepares the code for the no-cond-assign ESLint rule. PR-URL: #41614 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Jan 24, 2022 · 301a4f8 · 301a4f8
1 parent 0e35d01
commit 301a4f8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/repl.js b/lib/repl.js
@@ -381,7 +381,7 @@ function REPLServer(prompt,
     paused = false;
     let entry;
     const tmpCompletionEnabled = self.isCompletionEnabled;
-    while (entry = ArrayPrototypeShift(pausedBuffer)) {
+    while ((entry = ArrayPrototypeShift(pausedBuffer)) !== undefined) {
       const { 0: type, 1: payload, 2: isCompletionEnabled } = entry;
       switch (type) {
         case 'key': {
@@ -1450,7 +1450,7 @@ function complete(line, callback) {
       ArrayPrototypePush(completionGroups,
                          getGlobalLexicalScopeNames(this[kContextId]));
       let contextProto = this.context;
-      while (contextProto = ObjectGetPrototypeOf(contextProto)) {
+      while ((contextProto = ObjectGetPrototypeOf(contextProto)) !== null) {
         ArrayPrototypePush(completionGroups,
                            filteredOwnPropertyNames(contextProto));
       }