Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failures on canary #44

Closed
targos opened this issue Mar 22, 2018 · 2 comments
Closed

Test failures on canary #44

targos opened this issue Mar 22, 2018 · 2 comments

Comments

@targos
Copy link
Member

targos commented Mar 22, 2018

CI run: https://ci.nodejs.org/job/node-test-commit-linux/17279/nodes=centos7-64/console

05:25:12 not ok 1218 parallel/test-postmortem-metadata # TODO : Fix flaky test
05:25:12   ---
05:25:12   duration_ms: 1.949
05:25:12   severity: flaky
05:25:12   stack: |-
05:25:12     assert.js:80
05:25:12       throw new AssertionError(obj);
05:25:12       ^
05:25:12     
05:25:12     AssertionError [ERR_ASSERTION]: Missing constants: v8dbg_class_SharedFunctionInfo__raw_name__Object,v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
05:25:12         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos7-64/test/parallel/test-postmortem-metadata.js:48:8)
05:25:12         at Module._compile (internal/modules/cjs/loader.js:677:30)
05:25:12         at Object.Module._extensions..js (internal/modules/cjs/loader.js:688:10)
05:25:12         at Module.load (internal/modules/cjs/loader.js:588:32)
05:25:12         at tryModuleLoad (internal/modules/cjs/loader.js:527:12)
05:25:12         at Function.Module._load (internal/modules/cjs/loader.js:519:3)
05:25:12         at Function.Module.runMain (internal/modules/cjs/loader.js:718:10)
05:25:12         at startup (internal/bootstrap/node.js:225:19)
05:25:12         at bootstrapNodeJSCore (internal/bootstrap/node.js:570:3)
05:25:12   ...

05:26:16 not ok 1716 parallel/test-v8-stats
05:26:16   ---
05:26:16   duration_ms: 0.139
05:26:16   severity: fail
05:26:16   stack: |-
05:26:16     assert.js:80
05:26:16       throw new AssertionError(obj);
05:26:16       ^
05:26:16     
05:26:16     AssertionError [ERR_ASSERTION]: [ 'code_space',
05:26:16       'large_object_space',
05:26:16       'map_space',
05:26:16       'new_space',
05:26:16       'old_space',
05:26:16       'read_only_space' ] deepStrictEqual [ 'code_space',
05:26:16       'large_object_space',
05:26:16       'map_space',
05:26:16       'new_space',
05:26:16       'old_space' ]
05:26:16         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos7-64/test/parallel/test-v8-stats.js:32:8)
05:26:16         at Module._compile (internal/modules/cjs/loader.js:677:30)
05:26:16         at Object.Module._extensions..js (internal/modules/cjs/loader.js:688:10)
05:26:16         at Module.load (internal/modules/cjs/loader.js:588:32)
05:26:16         at tryModuleLoad (internal/modules/cjs/loader.js:527:12)
05:26:16         at Function.Module._load (internal/modules/cjs/loader.js:519:3)
05:26:16         at Function.Module.runMain (internal/modules/cjs/loader.js:718:10)
05:26:16         at startup (internal/bootstrap/node.js:225:19)
05:26:16         at bootstrapNodeJSCore (internal/bootstrap/node.js:570:3)
05:26:16   ...
@cjihrig
Copy link

cjihrig commented Mar 22, 2018

I can look into this one.

cjihrig added a commit to cjihrig/node-v8 that referenced this issue Mar 27, 2018
@cjihrig
test: add read_only_space heap space
a682b9b 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: nodejs#44
cjihrig added a commit to cjihrig/node-v8 that referenced this issue Mar 27, 2018
@cjihrig
test: update postmortem metadata test
c8e20b6 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: nodejs#44
@cjihrig cjihrig mentioned this issue Mar 27, 2018
Closed
3 tasks
@cjihrig
Copy link

cjihrig commented Mar 27, 2018

Fixes in #47

targos pushed a commit to nodejs/node that referenced this issue Mar 28, 2018
@cjihrig @targos
test: add read_only_space heap space
8512818 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: nodejs/node-v8#44
targos pushed a commit to nodejs/node that referenced this issue Mar 28, 2018
@cjihrig @targos
test: update postmortem metadata test
1ba1209 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: nodejs/node-v8#44
@targos targos closed this as completed Mar 28, 2018
nodejs-ci pushed a commit that referenced this issue Mar 29, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
a463137 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Mar 29, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
89d396a 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Mar 30, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
5d0e17e 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Mar 30, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
9edd443 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Mar 31, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
d7d9ae6 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Mar 31, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
2d7972f 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: #44
targos pushed a commit to nodejs/node that referenced this issue Apr 3, 2018
@cjihrig @targos
test: add read_only_space heap space
f537fa6 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: nodejs/node-v8#44
targos pushed a commit to nodejs/node that referenced this issue Apr 3, 2018
@cjihrig @targos
test: update postmortem metadata test
e022656 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: nodejs/node-v8#44
nodejs-ci pushed a commit that referenced this issue Apr 3, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
e9482ce 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Apr 3, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
7ebb9eb 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Apr 4, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
d07b83c 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Apr 4, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
832bd82 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Apr 4, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
1c64882 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Apr 4, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
1aea7f5 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: #44
targos pushed a commit to nodejs/node that referenced this issue Apr 5, 2018
@cjihrig @targos
test: add read_only_space heap space
9a00c55 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: nodejs/node-v8#44
targos pushed a commit to nodejs/node that referenced this issue Apr 5, 2018
@cjihrig @targos
test: update postmortem metadata test
84a1e1b 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: nodejs/node-v8#44
nodejs-ci pushed a commit that referenced this issue Apr 5, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
a3aab67 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Apr 5, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
20b5f91 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: #44
targos pushed a commit to nodejs/node that referenced this issue Apr 7, 2018
@cjihrig @targos
test: add read_only_space heap space
0b3e09a 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: nodejs/node-v8#44
targos pushed a commit to nodejs/node that referenced this issue Apr 7, 2018
@cjihrig @targos
test: update postmortem metadata test
d734f4e 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: nodejs/node-v8#44
nodejs-ci pushed a commit that referenced this issue Apr 7, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
d0d2e59 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue Apr 7, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
e0d5ab7 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

Fixes: #44
targos pushed a commit to nodejs/node that referenced this issue May 24, 2018
@cjihrig @targos
test: update postmortem metadata test
80384d8 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

- v8dbg_class_SharedFunctionInfo__compiler_hints__int
  - Renamed: v8dbg_class_SharedFunctionInfo__flags__int
  - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b

Fixes: nodejs/node-v8#44
Fixes: nodejs/node-v8#48
nodejs-ci pushed a commit that referenced this issue May 25, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
278b0d6 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue May 25, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
10a8991 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

- v8dbg_class_SharedFunctionInfo__compiler_hints__int
  - Renamed: v8dbg_class_SharedFunctionInfo__flags__int
  - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b

Fixes: #44
Fixes: #48
nodejs-ci pushed a commit that referenced this issue May 26, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
098cf0a 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue May 26, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
b2fd018 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

- v8dbg_class_SharedFunctionInfo__compiler_hints__int
  - Renamed: v8dbg_class_SharedFunctionInfo__flags__int
  - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b

Fixes: #44
Fixes: #48
targos pushed a commit to nodejs/node that referenced this issue May 29, 2018
@cjihrig @targos
test: add read_only_space heap space
33c19f4 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: nodejs/node-v8#44
targos pushed a commit to nodejs/node that referenced this issue May 29, 2018
@cjihrig @targos
test: update postmortem metadata test
9690632 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

- v8dbg_class_SharedFunctionInfo__compiler_hints__int
  - Renamed: v8dbg_class_SharedFunctionInfo__flags__int
  - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b

Fixes: nodejs/node-v8#44
Fixes: nodejs/node-v8#48
nodejs-ci pushed a commit that referenced this issue May 29, 2018
@cjihrig @nodejs-ci
test: add read_only_space heap space
a0c2d3a 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: #44
nodejs-ci pushed a commit that referenced this issue May 29, 2018
@cjihrig @nodejs-ci
test: update postmortem metadata test
c9dc1bb 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

- v8dbg_class_SharedFunctionInfo__compiler_hints__int
  - Renamed: v8dbg_class_SharedFunctionInfo__flags__int
  - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b

Fixes: #44
Fixes: #48
targos pushed a commit to targos/node that referenced this issue May 31, 2018
@cjihrig @targos
test: add read_only_space heap space
ede9f16 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: nodejs/node-v8#44
targos pushed a commit to targos/node that referenced this issue May 31, 2018
@cjihrig @targos
test: update postmortem metadata test
53725c9 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

- v8dbg_class_SharedFunctionInfo__compiler_hints__int
  - Renamed: v8dbg_class_SharedFunctionInfo__flags__int
  - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b

Fixes: nodejs/node-v8#44
Fixes: nodejs/node-v8#48
MylesBorins pushed a commit to nodejs/node that referenced this issue Jun 1, 2018
@cjihrig @MylesBorins
test: add read_only_space heap space
9380c18 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: nodejs/node-v8#44

PR-URL: #19989
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this issue Jun 1, 2018
@cjihrig @MylesBorins
test: update postmortem metadata test
d6edb6c 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

- v8dbg_class_SharedFunctionInfo__compiler_hints__int
  - Renamed: v8dbg_class_SharedFunctionInfo__flags__int
  - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b

Fixes: nodejs/node-v8#44
Fixes: nodejs/node-v8#48

PR-URL: #19989
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this issue Jun 1, 2018
@cjihrig @MylesBorins
test: add read_only_space heap space
aa08f64 
v8.getHeapSpaceStatistics() now includes read_only_space
in its results. Update test-v8-stats.js to account for this.

Fixes: nodejs/node-v8#44

PR-URL: #19989
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this issue Jun 1, 2018
@cjihrig @MylesBorins
test: update postmortem metadata test
df97791 
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

- v8dbg_class_SharedFunctionInfo__compiler_hints__int
  - Renamed: v8dbg_class_SharedFunctionInfo__flags__int
  - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b

Fixes: nodejs/node-v8#44
Fixes: nodejs/node-v8#48

PR-URL: #19989
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
nodejs-ci pushed a commit that referenced this issue Aug 24, 2019
@isaacs @Trott
deps: update npm to 6.10.3
f769034 
BUGFIXES

* [`27cccfbda`](npm/cli@27cccfb)
  [#223](npm/cli#223) vulns → vulnerabilities in
  npm audit output ([@sapegin](https://github.com/sapegin))
* [`d5e865eb7`](npm/cli@d5e865e)
  [#222](npm/cli#222)
  [#226](npm/cli#226) install, doctor: don't crash
  if registry unset ([@dmitrydvorkin](https://github.com/dmitrydvorkin),
  [@isaacs](https://github.com/isaacs))
* [`5b3890226`](npm/cli@5b38902)
  [#227](npm/cli#227)
  [npm.community#9167](https://npm.community/t/npm-err-cb-never-called-permission-denied/9167/5)
  Handle unhandledRejections, tell user what to do when encountering an
  `EACCES` error in the cache.  ([@isaacs](https://github.com/isaacs))

DEPENDENCIES

* [`77516df6e`](npm/cli@77516df)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`ceb993590`](npm/cli@ceb9935)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`4050b9189`](npm/cli@4050b91)
  `[email protected]`
    * [#46](npm/hosted-git-info#46)
      [#43](npm/hosted-git-info#43)
      [#47](npm/hosted-git-info#47)
      [#44](npm/hosted-git-info#44) Add support for
      GitLab subgroups ([@mterrel](https://github.com/mterrel),
      [@isaacs](https://github.com/isaacs),
      [@ybiquitous](https://github.com/ybiquitous))
    * [`3b1d629`](npm/hosted-git-info@3b1d629)
      [#48](npm/hosted-git-info#48) fix http
      protocol using sshurl by default
      ([@fengmk2](https://github.com/fengmk2))
    * [`5d4a8d7`](npm/hosted-git-info@5d4a8d7)
      ignore noCommittish on tarball url generation
      ([@isaacs](https://github.com/isaacs))
    * [`1692435`](npm/hosted-git-info@1692435)
      use gist tarball url that works for anonymous gists
      ([@isaacs](https://github.com/isaacs))
    * [`d5cf830`](npm/hosted-git-info@d5cf830)
      Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
    * [`e518222`](npm/hosted-git-info@e518222)
      Use LRU cache to prevent unbounded memory consumption
      ([@iarna](https://github.com/iarna))

PR-URL: nodejs/node#29023
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @cjihrig