Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No canary builds during a month #222

Closed
vsemozhetbyt opened this issue Apr 20, 2022 · 7 comments
Closed

No canary builds during a month #222

vsemozhetbyt opened this issue Apr 20, 2022 · 7 comments

Comments

@vsemozhetbyt
Copy link

The last build is https://direct.nodejs.org/download/v8-canary/v18.0.0-v8-canary20220323849445f546/

@targos
Copy link
Member

targos commented Apr 20, 2022

I don't know why there's nothing in the v8-canary folder. Release builds are green. For example yesterday:
https://ci-release.nodejs.org/job/iojs+release/8404/
image

@nodejs/build-infra

@targos
Copy link
Member

targos commented Apr 20, 2022

The files are copied to custom. That's probably the cause of the problem.

13:06:58 scp -p node-v18.0.0-v8-canary20220419dfe2c32b5e-linux-x64.tar.xz node-www:nodejs/custom/v18.0.0-v8-canary20220419dfe2c32b5e/node-v18.0.0-v8-canary20220419dfe2c32b5e-linux-x64.tar.xz

@richardlau
Copy link
Member

The files are copied to custom. That's probably the cause of the problem.

13:06:58 scp -p node-v18.0.0-v8-canary20220419dfe2c32b5e-linux-x64.tar.xz node-www:nodejs/custom/v18.0.0-v8-canary20220419dfe2c32b5e/node-v18.0.0-v8-canary20220419dfe2c32b5e-linux-x64.tar.xz

Unlikely, that has always been the case -- the builds are staged in custom and the promotion script is supposed to be copying the files to v8-canary based on the directory name: https://github.com/nodejs/build/blob/5e2ae08283c75eff51de04635883446dce23ad8b/ansible/www-standalone/tools/promote/settings#L16-L18

Given the timings, I think what may have happened is that the test build I was running while adding new release machines for Node.js 18 has caused an issue while promoting test builds and making the promotion script bail before promoting v8-canary (the order is nightly, next-nightly, rc, test, v8-canary:
https://github.com/nodejs/build/blob/371bb7626abe773a56c7c62e76d0a551ba1b9717/ansible/www-standalone/tools/promote/promote_nightly.sh#L14-L43). I'll try to figure out what that is and how to recover.

@richardlau
Copy link
Member

Running the promotion script as the dist user appears to back up that theory -- v18.0.0-test202202249be1dcff34 was the identifier for the test builds I ran:

$ /home/staging/tools/promote/promote_nightly.sh nodejs
Promoting v18.0.0-test202202249be1dcff34/node-v18.0.0-test202202249be1dcff34-linux-arm64.tar.gz...
cp: cannot create regular file '/home/dist/nodejs/test/v18.0.0-test202202249be1dcff34/node-v18.0.0-test202202249be1dcff34-linux-arm64.tar.gz': Permission denied

I suspect I've run into nodejs/build#2020 where the destination dist directory intentionally had its permissions changed and I was running builds with the same identifier over more than a five day period. I don't need the v18.0.0-test202202249be1dcff34 build, so I'll remove the unpromoted assets from staging.

@richardlau
Copy link
Member

Looks promising:

$ /home/staging/tools/promote/promote_nightly.sh nodejs
Promoting v18.0.0-v8-canary20220324863bb10b2d/docs...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-aix-ppc64.tar.gz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-darwin-arm64.tar.gz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-darwin-arm64.tar.xz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-darwin-x64.tar.gz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-darwin-x64.tar.xz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-headers.tar.gz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-headers.tar.xz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-linux-arm64.tar.gz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-linux-arm64.tar.xz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-linux-armv7l.tar.gz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-linux-armv7l.tar.xz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-linux-ppc64le.tar.gz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-linux-ppc64le.tar.xz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-linux-s390x.tar.gz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-linux-s390x.tar.xz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-linux-x64.tar.gz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-linux-x64.tar.xz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d.pkg...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d.tar.gz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d.tar.xz...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-win-x64.7z...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-win-x64.zip...
Promoting v18.0.0-v8-canary20220324863bb10b2d/node-v18.0.0-v8-canary20220324863bb10b2d-x64.msi...
Promoting v18.0.0-v8-canary20220324863bb10b2d/win-x64...
/home/dist/nodejs/v8-canary/v18.0.0-v8-canary20220324863bb10b2d/SHASUMS256.txt
Promoting v18.0.0-v8-canary20220325de62049e54/docs...
...

@richardlau
Copy link
Member

The missing canary builds are all now available.

@vsemozhetbyt
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants