Code And Learn at NodeFest 2016 #58
Comments
|
Contributing Point: doc typo:
doc improvement:
|
|
If you need more issues, one thing you can do is search through the test files for |
|
Contributing Point: test:
const server = http.createServer((req, res) => {
if (req.url === '/explicit') {
explicit(req, res);
} else {
implicit(req, res);
}
}).listen(common.PORT, common.mustCall(() => { // should use 0
const url = `http://localhost:${common.PORT}`; // should use server.address().port
let left = 2;
const check = common.mustCall((res) => {
left--;
assert.notEqual(res.headers['content-type'], 'text/html');
assert.notEqual(res.headers['content-type'], 'gotcha');
if (left === 0) server.close();
}, 2);
http.get(`${url}/explicit`, check).end();
http.get(`${url}/implicit`, check).end();
})); |
|
@Trott thank you!!! sound so good. I am currently searching contribution point on code-and-learn on nodefest. |
|
Here's another one: There are a number of instances of Here are some of those cases. I have not reviewed them to verify that
|
|
test: use port 0 instead of common.PORT
server.listen(common.PORT, function() { // use 0 port
socket = net.connect(common.PORT, '127.0.0.1', socketConnected); // use server.address().port
});
|
@ronkorving is a collaborator and lives in Tokyo. |
|
@Trott ah, that's so good. |
|
@Trott @yosuke-furukawa Indeed :) I'm not too active in the Japanese Node community, but wouldn't mind trying harder :) My Japanese is not yet 100% what I would like it to be. In any case, I signed up for Sunday (visitor) and wouldn't mind helping with the organization next year either if that's appreciated. I'll see you on Sunday. 楽しみにしてます ^^ |
|
@yosuke-furukawa I'm definitely looking forward to being there and will help out in whatever way that I can. I just want to confirm that the Code and Learn is scheduled for Saturday afternoon, correct? I want to take a little bit of time Saturday morning to sight see a little bit and I want to make sure I plan things so I won't be late to the Code and Learn :-) |
|
I'm going to join it to help participants and take care of what tests and docs can be good for the first contributions. But actually, the class is just one and half hour so I think it is too short for novices. Instead of submitting a new PR to nodejs repo, I made an alternative repo of node to give such users the first experiences of contributions in https://github.com/shigeki/node_testpr/ . It can be a training for them if they submit a fake PR such as shigeki/node_testpr#1 . Users can choice which repo they want to work on during the course. |
|
I've just submitted some issues of test failures to be reserved for this course in nodejs/node#9509, nodejs/node#9510 and nodejs/node#9511 |
Yes!!! Code And Learn will begin 15:45 on Saturday, and the end time is 17:15. And I really would like you to attend NodeDiscussion on Saturday morning, almost 90 min (11:00-12:30). This discussion is unconference style. We would like to discuss about Node.js good point/bad point/wishlist. I would like share our opinions to node core committers. If you don't have any time on Saturday morning, it is OK, but if you have time, please come!!!!! |
|
@ronkorving Ya!!! please help us !!!! You can come our venue and speak to our receptionist as |
|
@shigeki awesome!!! I will wrap up these contribution point on this Thursday. |
You can remove that one from the list as I'm in the process of fixing it while refactoring a bunch of other things in the test. Sorry about that. You can replace it, though with these tests which all have at least one instance of
|
|
@yosuke-furukawa Sounds good, I'll try to make it! :) Basically just show up before 3:45? |
|
@Trott thank you soooooooooooooooo much!!!!!!!!!!!!!!!!!!!!!! |
|
@ronkorving Yes! we will start at 15:45 on dots Shibuya, tokyo. https://eventdots.jp/space |
|
https://coverage.nodejs.org/coverage-fb05e31466ac0bad/root/internal/process/stdio.js.html
|
|
@Fishrock123 |
|
All contribution point:
doc improvement:
test assertion improvement:
test failure with build option :
test timing API improvement:
test use port:0 instead of common.PORT :
coverage improvement:
https://coverage.nodejs.org/coverage-fb05e31466ac0bad/root/internal/process/stdio.js.html |
We have a lint rule for that so you shouldn't find any examples of |
|
@Trott OK, I updated. |
|
i will try to fix this |
|
I will try to fix |
This commit adds the test case of PassThrough. This test case checks that PassThrough can construct without new operator. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9581 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
use setImmediate() insted of setTimeout() in test of stream2 push. The test is in test/parallel/test-stream2-push.js Fixes: nodejs/code-and-learn#58 PR-URL: #9583 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
This commit improves the test cases in test-stream2-objects.js by using assert.strictEqual instead of assert.equal. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9565 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This is a part of Code And Learn at NodeFest 2016 Challenge Fixes: nodejs/code-and-learn#58 PR-URL: #9578 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This commit adds the test case of PassThrough. This test case checks that PassThrough can construct without new operator. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9581 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
use setImmediate() insted of setTimeout() in test of stream2 push. The test is in test/parallel/test-stream2-push.js Fixes: nodejs/code-and-learn#58 PR-URL: #9583 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
fix e.g., to e.g. in doc/http.md Fixes: nodejs/code-and-learn#58 PR-URL: #9564 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
fix doc/tls.md: line 762 836 1026 e.g., => e.g. Fixes: nodejs/code-and-learn#58 PR-URL: #9566 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
Fixes: nodejs/code-and-learn#58 PR-URL: #9568 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
Fixes: nodejs/code-and-learn#58 PR-URL: #9563 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
fix doc/api/repl.md line 6 "includable" => "includible" Fixes: nodejs/code-and-learn#58 PR-URL: #9582 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
fix e.g., to e.g. in doc/http.md Fixes: nodejs/code-and-learn#58 PR-URL: #9564 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
Fixes: nodejs/code-and-learn#58 PR-URL: #9568 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
Fixes: nodejs/code-and-learn#58 PR-URL: #9563 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
This commit improves the test cases in test-stream2-objects.js by using assert.strictEqual instead of assert.equal. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9565 Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This is a part of Code And Learn at NodeFest 2016 Challenge Fixes: nodejs/code-and-learn#58 PR-URL: #9578 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This commit adds the test case of PassThrough. This test case checks that PassThrough can construct without new operator. This is a part of Code And Learn at NodeFest 2016 Fixes: nodejs/code-and-learn#58 PR-URL: #9581 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
use setImmediate() insted of setTimeout() in test of stream2 push. The test is in test/parallel/test-stream2-push.js Fixes: nodejs/code-and-learn#58 PR-URL: #9583 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]>
PR-URL: #18369 Fixes: nodejs/code-and-learn#58 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #18369 Fixes: nodejs/code-and-learn#58 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #18369 Fixes: nodejs/code-and-learn#58 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: nodejs#18369 Fixes: nodejs/code-and-learn#58 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Hi folks.
NodeFest is the largest Node.js conference at Japan.
I am an organizer of the conference, I would like to open code-and-learn-jp on NodeFest.
Japan has 1 collaborator (me) and 1 core team member (shigeki) and some great nodeschool staffs (martin, ledsun, watilde, tako-black, etc). We would like to support contribution to nodejs/core.
And I would like to list up the contribution point of Japanese node beginners.
I guess we will receive some PRs on 12th November.
We will follow English communication and some other commit techniques.
The text was updated successfully, but these errors were encountered: