test failures of v8 inspectors build without dependencies

[shigeki]

• Version: v8.0.0-pre
• Platform: all
• Subsystem: test

Several tests of v8-inspector fails due to missing check of its dependencies of

def configure_inspector(o):
  disable_inspector = (options.without_inspector or
                       options.with_intl in (None, 'none') or
                       options.without_ssl)
  o['variables']['v8_inspector'] = b(not disable_inspector)

The issue can be reproduced as

$ ./configure --without-ssl
$ make
$ make test
(snip)
[00:39|% 100|+ 1272|-   3]: Done

This issue is reserved to be fixed in the course of Code and Learn in Node Fest Tokyo 2016.

Ref: nodejs/code-and-learn#58

[spacekitteh]

so does that mean i have to wait for nodefest 2016 for this to be fixed?! it's not just a test failure, since i can't use LibreSSL with nodejs, i disabled SSL altogether for it. so it seems it's build with openssl or don't build at all...

[shigeki]

Nodefest has already been over. This issue is open to everyone.
But be sure that this is only for a test failure built with --without-ssl. The issue in regard to LibreSSL should be filed to an another issue.

[evenstensberg]

@shigeki What dependencies should it have, of which it doesn't? Have you found any cause or leaks yet?

[evenstensberg]

FWIW, o['variables']['v8_inspector'] is suppose to be true, yes? If supplied with that boolean, it cannot compile openssl

[sotayamashita]

@ev1stensberg Are you working this issue ?

[evenstensberg]

@sotayamashita I do want to but need some advice. Otherwise, I'm quite busy, would be okay to pass it along to someone else. Evidently this would be a nice first contribution for me.

[sotayamashita]

@ev1stensberg I can help you. Have you ever run test @shigeki mention above?

[evenstensberg]

2months since I did this, but traced down the flags passed down, I remember thinking they were set / adjusted wrongly.

[Trott]

I just ran configure --without-ssl && make -j4 test and all tests passed. I think @danbev fixed these and a bunch more over time. Closing. Please comment or re-open if that's wrong. Thanks!