jenkins: only run sharedlibs_debug_x64 pre-18 #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full debug x64 builds have been unreliable in the CI in the sharedlibs containers and were recently "turned off" by making the job a no-op. However the job was still being started even if it didn't do anything but pass -- this change prevents Jenkins from starting `sharedlibs_debug_x64` runs. Refs: #2837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full debug x64 builds have been unreliable in the CI in the sharedlibs
containers and were recently "turned off" by making the job a no-op.
However the job was still being started even if it didn't do anything
but pass -- this change prevents Jenkins from starting
sharedlibs_debug_x64runs.Refs: #2837
cc @mhdawson
We may end up reintroducing a "lighter" debug build (suggested in nodejs/node#41209 (comment)) later but that would probably be better in its own job and not part of node-test-commit-linux-containered.