Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA - added node-test-commit-arm-debug to node-test-commit #2837

Closed
mhdawson opened this issue Dec 22, 2021 · 9 comments
Closed

PSA - added node-test-commit-arm-debug to node-test-commit #2837

mhdawson opened this issue Dec 22, 2021 · 9 comments
Labels

Comments

@mhdawson
Copy link
Member

Added node-test-commit-arm-debug job to node-test-commit as next step in: nodejs/node#41209.

It's configured to only run the build/test > 17, and otherwise just pass as a job.

Will close this once we turn off the x86 debug builds and all has run ok for a few days.

@mhdawson
Copy link
Member Author

I should have also noted that it will show as yellow until we investigate: nodejs/node#41204

@mhdawson
Copy link
Member Author

Updated configuration for
https://ci.nodejs.org/job/node-test-commit-linux-containered/

so that the debug build only runs if major version is less than or equal to 17

@richardlau
Copy link
Member

We usually do exclusions based on Node.js release lines in https://github.com/nodejs/build/blob/master/jenkins/scripts/VersionSelectorScript.groovy.

@mhdawson
Copy link
Member Author

As far as I understand the groovy selector allows us to not run based on machine tag (ex ubuntu2004), not sure how that translates to this case.

If you have suggestion for an alternate change to the groovy script that would help illustrate what you are suggesting.

@richardlau
Copy link
Member

So for example

[ /sharedlibs_openssl300/, anyType, lt(15) ],
means that the dynamically linked OpenSSL 3 bit of linux-containered doesn't run for Node.js versions earlier than 15.
[ /sharedlibs_openssl102/, anyType, gte(10) ],
says to not run dynamically linked OpenSSL 1.0.2 for Node.js 10 and later.

So we can add a rule for sharedlibs_debug or sharedlibs_debug_x64 if you want to be more specific (it's a regexp match afterall).

@mhdawson
Copy link
Member Author

mhdawson commented Dec 22, 2021

Ok we can update the groovy script for the part related to the x86 containers. Interestingly if you look at the actual contained job, there was already a check for > version 8. I just added the second check for <= 17

image

So it looks like there is some configuration in the CI job as well. Maybe that was just missed?

@richardlau
Copy link
Member

I'd imagine the existing condition predates the introduction of the groovy script.

richardlau added a commit that referenced this issue Apr 13, 2022
Full debug x64 builds have been unreliable in the CI in the sharedlibs
containers and were recently "turned off" by making the job a no-op.
However the job was still being started even if it didn't do anything
but pass -- this change prevents Jenkins from starting 
`sharedlibs_debug_x64` runs.

Refs: #2837
@richardlau
Copy link
Member

So we can add a rule for sharedlibs_debug or sharedlibs_debug_x64 if you want to be more specific (it's a regexp match afterall).

Opened #2925.

richardlau added a commit that referenced this issue Apr 14, 2022
Full debug x64 builds have been unreliable in the CI in the sharedlibs
containers and were recently "turned off" by making the job a no-op.
However the job was still being started even if it didn't do anything
but pass -- this change prevents Jenkins from starting 
`sharedlibs_debug_x64` runs.

Refs: #2837
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Feb 8, 2023
@mhdawson mhdawson closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants