-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jenkins: osx10.15 release for 13.x #2202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
added a commit
that referenced
this pull request
Mar 4, 2020
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
rvagg
force-pushed
the
rvagg/osx1015-13.x
branch
from
March 5, 2020 04:06
22076b5
to
4115a87
Compare
rvagg
added a commit
that referenced
this pull request
Mar 5, 2020
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
This was referenced Mar 13, 2020
AshCripps
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it needs a rebasing, also is the non-ansible-config file need in this pr or has that already landed?
rvagg
force-pushed
the
rvagg/osx1015-13.x
branch
from
March 16, 2020 11:02
4115a87
to
8a00460
Compare
rvagg
force-pushed
the
rvagg/osx1015-13.x
branch
from
March 16, 2020 11:03
8a00460
to
630e4a4
Compare
cleaned up the doc commit difference, it's just the versionselectorscript changes |
rvagg
added a commit
that referenced
this pull request
Mar 30, 2020
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
rvagg
added a commit
that referenced
this pull request
Mar 30, 2020
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
rvagg
added a commit
that referenced
this pull request
Mar 30, 2020
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
rvagg
added a commit
that referenced
this pull request
Mar 30, 2020
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lands on top of #2199, after we get that one landed landed, nodejs/node#31459 landed and a few nightlies out without any problems.
See timeline in #2199 (comment)