-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jenkins & docs: macOS 10.15 #2199
Conversation
I've added release builder manual setup notes to this PR too. @AshCripps is there a better place for these to go now after reorg? Unfortunately you need the full Xcode (as far as I can figure) to get notarized builds, so I've added some instructions to do that manually. I don't think much of this can be automated with Ansible unfortunately and it's all a bit of a hassle. I have a release job for testing this all out @ https://ci-release.nodejs.org/job/iojs+release-rvagg-osx1015 (releasers only sorry) but I still haven't got all the way yet. The remaining piece of the puzzle is getting the password for the notarization into and out of the keychain!
^ I can replicate that directly on the command line too so it's easy to test. |
Spun my wheels more on the keychain stuff, my conclusion is that this process isn't designed for fully headless servers, it assumes a full session which I can't replicate in this environment. Instead, I've put the password into Jenkins' credentials list and exposed it in the build job as Have successfully produced a notarized build for This needs to be applied to all other branches too before this PR can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the doc placement. With regards to iojs user not being setup via the UI we can access the UI of these machines, I can share the details with you if you think it would be beneficial to do some setup that way.
@AshCripps I'd prefer to stick with non-UI where possible I think. This set of instructions will do and maybe when we set up the next release machine we can learn a bit more and simplify. I've marked this PR as ready to be reviewed & merged if anyone else has input. Here's my proposed plan of attack as separate steps, expanding on what we discussed in today's meeting:
For all of the releases we'll need to make sure that the releaser includes a note about the changed build environment and the minor potential for breakage. We should come up with some text for that. |
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
@rvagg I think you've picked up some extra commits in this PR? |
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
thanks, cleaned up |
nodejs/node#31459 is landed, next step is getting this landed. It was already approved but I've just changed it to move the docs from doc/non-ansible-configuration-notes.md to ansible/MANUAL_STEPS.md where I think they really belong. The change also updates the TOC, I use the VSCode Markdown All In One plugin to do TOCs automatically so it's been edited quite heavily to make it consistent (lower-case anchors, names exact matching titles). So I'd prefer additional signoff before landing. @richardlau you only just updated the TOC, so you might want to look at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
Ref: #2199 Ref: #2202 Ref: nodejs/node#31459
WIP focusing on releases for now. This'll eventually need to be 10.15 for all release types and we'll need it in for test jobs too if that's not done by some other PR.