Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configureGamePass #813

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Conversation

Regalijan
Copy link
Member

  • Use new endpoint
  • Fix request dying because of non-string form values
  • Don't tell Roblox it's a PNG when it isn't

Error handling could be a bit better but I'm saving that for #800

@Regalijan Regalijan requested a review from alanbixby July 24, 2024 05:21
Copy link
Member

@Neztore Neztore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy but won't merge since I see there's a pending review from Alan

Copy link
Member

@alanbixby alanbixby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs updated typings documented; the old response is a Promise<GamePassResponse>, but it appears the new endpoint would be a Promise<void>.

This should be documented in the local JSDocs comment, typings/jsDocs.ts, and typings/index.d.ts

Copy link
Member

@alanbixby alanbixby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retracting comment about types - the response is manually returning data about the endpoint, so the return type is the same. No updates to types needed.

@Neztore Neztore merged commit 2bc2f3b into noblox:master Aug 1, 2024
2 checks passed
@Regalijan Regalijan deleted the update-gamepass-endpoint branch September 15, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants