-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configureGamePass #813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy but won't merge since I see there's a pending review from Alan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs updated typings documented; the old response is a Promise<GamePassResponse>
, but it appears the new endpoint would be a Promise<void>
.
This should be documented in the local JSDocs comment, typings/jsDocs.ts
, and typings/index.d.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retracting comment about types - the response is manually returning data about the endpoint, so the return type is the same. No updates to types needed.
Error handling could be a bit better but I'm saving that for #800