Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Global error class #800

Open
Regalijan opened this issue May 21, 2024 · 0 comments · May be fixed by #841
Open

[FEATURE] Global error class #800

Regalijan opened this issue May 21, 2024 · 0 comments · May be fixed by #841
Labels
enhancement New feature or request

Comments

@Regalijan
Copy link
Member

Right now each method has its own error parser (if any). Apart from it being very repetitive, it does not work for certain error responses (i.e those not contained within an errors array).

I would like to move this to a class so that we're not reimplementing an error parser for every method.

Ideally, this class would:

  • Handle most known error responses (i.e what the current parsers can handle, csrf errors, and certain 5xx errors that don't return a proper response body)
  • Expose properties containing the status code and original response body

(If we're going to be honest this is more of an RFC)

This would probably be a v5 release target given that it could be breaking in some cases (could be pushed back).

@Regalijan Regalijan added the enhancement New feature or request label May 21, 2024
@Regalijan Regalijan linked a pull request Oct 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant