Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add identityattribute introduction #170

Merged
merged 38 commits into from
May 24, 2024
Merged

Feature/add identityattribute introduction #170

merged 38 commits into from
May 24, 2024

Conversation

vinzlange
Copy link
Contributor

No description provided.

@vinzlange
Copy link
Contributor Author

vinzlange commented Nov 27, 2023 •
edited
Loading

delayed until #164 is ready so that the links work and add link <!--- TODO: Insert link to "IdentityAttribute introduction" --->

@vinzlange vinzlange mentioned this pull request Jan 4, 2024
Merged
@vinzlange vinzlange requested review from britsta and stnmtz April 17, 2024 10:07
@britsta britsta marked this pull request as draft April 26, 2024 18:19
@britsta britsta marked this pull request as ready for review May 13, 2024 13:04
Milena-Czierlinski
Milena-Czierlinski reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this introduction and think it helps the reader tremendously understanding the following scenario better.

_docs_integrate/attribute-introduction.md Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
Milena-Czierlinski
Milena-Czierlinski reviewed May 17, 2024
View reviewed changes
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/01-integrate-scenarios.md Outdated Show resolved Hide resolved
_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
Milena-Czierlinski
Milena-Czierlinski reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the comments concerning ThirdPartyRelationshipAttributes, perhaps wait integrating them until we had our discussion about this topic, so you don't have to re-do the work.

_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Show resolved Hide resolved
_docs_integrate/attribute-introduction.md Outdated Show resolved Hide resolved
@britsta britsta merged commit 257246f into main May 24, 2024
5 checks passed
@britsta britsta deleted the Feature/add-identityattribute-introduction branch May 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski approved these changes

@britsta britsta Awaiting requested review from britsta

@stnmtz stnmtz Awaiting requested review from stnmtz stnmtz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinzlange @stnmtz @britsta @Milena-Czierlinski