Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add create own identity attribute description #164

Merged
merged 41 commits into from
Mar 5, 2024

Conversation

britsta
Copy link
Contributor

@britsta britsta commented Nov 2, 2023

Add scenario description for "Create own IdentityAttribute" -> Renaming to "Create Attribute for yourself" to be able to differentiate the scenario more clearly from the "Create a RepositoryAttribute" use case and also to be able to explain the creation of RelationshipAttributes

@britsta britsta marked this pull request as ready for review November 2, 2023 09:01
@vinzlange vinzlange self-requested a review December 8, 2023 11:39
vinzlange
vinzlange previously approved these changes Dec 8, 2023
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things mostly regarding language. Otherwise, this looks really good.

@britsta britsta merged commit f7e6761 into main Mar 5, 2024
5 checks passed
@britsta britsta deleted the feature/add-create-own-identity-attribute-description branch March 5, 2024 13:38
Milena-Czierlinski pushed a commit that referenced this pull request May 8, 2024
* feat: create own identityattribute init

(cherry picked from commit 2a36b68)

* feat: create own identityattribute

(cherry picked from commit f820de9)

* feat: create own identityattribute

(cherry picked from commit 188fb6d)

* feat: create own identityattribute

(cherry picked from commit 6b294bf)

* fix: adjust size of diagramm

(cherry picked from commit 7fa0ed9)

* fix: adjust size of diagramm

(cherry picked from commit 486d542)

* fix: remove dependent link temporarly

* fix: remove api excerpt on create attribute page

(cherry picked from commit 5686ce6)

* fix: make text more readable, embed new diagram

* fix: change terminology for requests, add usecases

* fix: replace http request payloads with tables

* fix: simplifying property notation

* fix: synchronize table with other documentations

* fix: remove comments on RelationshipAttributes

* fix: synchronize tables with other documentations

* fix: remove comments

* refactor: incorporate some review comments

* refactor: replace example tables with JSON payloads

* feat: replace input table with JSON payload

* feat: remove table of success response

* feat: adjust scenario because "Create an Attribute" use case will change

* refactor: add whitespaces in JSON comments

* refactor: renaming use cases

* refactor: renaming of scenario

* refactor: use new nomenclature for Attributes part 1

* refactor: use new nomenclature for Attributes part 2

* refactor: use new nomenclatur for Attributes part 3

* feat: add "Create RelationshipAttribute for yourself" part

* feat: add structure for "Create a RelationshipAttribute for yourself" section

* feat: add RelationshipAttribute creation with Read/Create/ProposeAttributeRequestItem

* feat: add RelationshipAttribute creation with ShareAttributeRequestItem

* feat: incorporate review comments

* feat: mention consumption.attributeCreated event

* feat: incorporate review comments

---------

Co-authored-by: Vinzent Lange <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants