-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add create own identity attribute description #164
Merged
britsta
merged 41 commits into
main
from
feature/add-create-own-identity-attribute-description
Mar 5, 2024
Merged
Feature/add create own identity attribute description #164
britsta
merged 41 commits into
main
from
feature/add-create-own-identity-attribute-description
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5686ce6)
vinzlange
previously approved these changes
Dec 8, 2023
jkoenig134
reviewed
Jan 4, 2024
jkoenig134
reviewed
Jan 4, 2024
jkoenig134
reviewed
Jan 4, 2024
jkoenig134
reviewed
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things mostly regarding language. Otherwise, this looks really good.
Milena-Czierlinski
approved these changes
Mar 5, 2024
britsta
deleted the
feature/add-create-own-identity-attribute-description
branch
March 5, 2024 13:38
Milena-Czierlinski
pushed a commit
that referenced
this pull request
May 8, 2024
* feat: create own identityattribute init (cherry picked from commit 2a36b68) * feat: create own identityattribute (cherry picked from commit f820de9) * feat: create own identityattribute (cherry picked from commit 188fb6d) * feat: create own identityattribute (cherry picked from commit 6b294bf) * fix: adjust size of diagramm (cherry picked from commit 7fa0ed9) * fix: adjust size of diagramm (cherry picked from commit 486d542) * fix: remove dependent link temporarly * fix: remove api excerpt on create attribute page (cherry picked from commit 5686ce6) * fix: make text more readable, embed new diagram * fix: change terminology for requests, add usecases * fix: replace http request payloads with tables * fix: simplifying property notation * fix: synchronize table with other documentations * fix: remove comments on RelationshipAttributes * fix: synchronize tables with other documentations * fix: remove comments * refactor: incorporate some review comments * refactor: replace example tables with JSON payloads * feat: replace input table with JSON payload * feat: remove table of success response * feat: adjust scenario because "Create an Attribute" use case will change * refactor: add whitespaces in JSON comments * refactor: renaming use cases * refactor: renaming of scenario * refactor: use new nomenclature for Attributes part 1 * refactor: use new nomenclature for Attributes part 2 * refactor: use new nomenclatur for Attributes part 3 * feat: add "Create RelationshipAttribute for yourself" part * feat: add structure for "Create a RelationshipAttribute for yourself" section * feat: add RelationshipAttribute creation with Read/Create/ProposeAttributeRequestItem * feat: add RelationshipAttribute creation with ShareAttributeRequestItem * feat: incorporate review comments * feat: mention consumption.attributeCreated event * feat: incorporate review comments --------- Co-authored-by: Vinzent Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scenario description for "Create own IdentityAttribute" -> Renaming to "Create Attribute for yourself" to be able to differentiate the scenario more clearly from the "Create a RepositoryAttribute" use case and also to be able to explain the creation of RelationshipAttributes