Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] network error leads to unwanted behavior #202

Merged
merged 4 commits into from
Jul 3, 2024
Merged

[SDK] network error leads to unwanted behavior #202

merged 4 commits into from
Jul 3, 2024

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Jul 3, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@sebbi08 sebbi08 added the bug Something isn't working label Jul 3, 2024
@sebbi08
Copy link
Contributor Author

sebbi08 commented Jul 3, 2024

When there is a network error between SDK and connector the errorPayload is undefined and the SDK crashes with an can not read property id of undefined

@jkoenig134 jkoenig134 changed the title Fix/SDK error message on network error was showing no details [SDK] network error lead to unwanted behavior Jul 3, 2024
@jkoenig134 jkoenig134 changed the title [SDK] network error lead to unwanted behavior [SDK] network error leads to unwanted behavior Jul 3, 2024
@sebbi08 sebbi08 merged commit d29559a into main Jul 3, 2024
9 checks passed
@sebbi08 sebbi08 deleted the feature/improve_error_in_sdk branch July 3, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@slavistan slavistan Awaiting requested review from slavistan

@tnotheis tnotheis Awaiting requested review from tnotheis

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebbi08 @jkoenig134 @slavistan