[SDK] network error leads to unwanted behavior (#202)

* fix: sdk error message on network error was showing not all details * Update packages/sdk/src/endpoints/Endpoint.ts Co-authored-by: Julian König <[email protected]> * fix: add error message on all places and only show path --------- Co-authored-by: Julian König <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nmshd · Jul 3, 2024 · d29559a · d29559a
1 parent f3a219d
commit d29559a
Showing 1 changed file with 17 additions and 1 deletion.
diff --git a/packages/sdk/src/endpoints/Endpoint.ts b/packages/sdk/src/endpoints/Endpoint.ts
@@ -47,7 +47,11 @@ export abstract class Endpoint {
 
         if (httpResponse.status !== expectedStatus) {
             const errorPayload = httpResponse.data.error;
-
+            if (!errorPayload) {
+                throw new Error(
+                    `The http request to connector route '${httpResponse.request.path}' failed with status '${httpResponse.status}': ${httpResponse.statusText} ${httpResponse.data}`
+                );
+            }
             return ConnectorResponse.error({
                 id: errorPayload.id,
                 docs: errorPayload.docs,
@@ -69,6 +73,12 @@ export abstract class Endpoint {
             // Manually parse data because responseType is "arrayBuffer"
             const errorPayload = JSON.parse(httpResponse.data).error;
 
+            if (!errorPayload) {
+                throw new Error(
+                    `The http request to connector route '${httpResponse.request.path}' failed with status '${httpResponse.status}': ${httpResponse.statusText} ${httpResponse.data}`
+                );
+            }
+
             return ConnectorResponse.error({
                 id: errorPayload.id,
                 docs: errorPayload.docs,
@@ -104,6 +114,12 @@ export abstract class Endpoint {
         if (httpResponse.status !== expectedStatus) {
             const errorPayload = httpResponse.data.error;
 
+            if (!errorPayload) {
+                throw new Error(
+                    `The http request to connector route '${httpResponse.request.path}' failed with status '${httpResponse.status}': ${httpResponse.statusText} ${httpResponse.data}`
+                );
+            }
+
             return ConnectorResponse.error({
                 id: errorPayload.id,
                 docs: errorPayload.docs,