Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use "source" for source names #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fricklerhandwerk
Copy link

this removes a difference to how Nix currently fetches flake references.

using a constant is preferrable because renaming the source won't force downstream rebuilds.

there probably is no correct solution here, as any choice for the
symbolic name is essentially arbitrary, and arguably symbolic names were
an unfortunate design decision anyway.

@infinisil @Ericson2314

this removes a difference to how Nix currently fetches flake references.

using a constant is preferrable because renaming the source won't force downstream rebuilds.

there probably is no correct solution here, as any choice for the
symbolic name is essentially arbitrary, and arguably symbolic names were
an unfortunate design decision anyway.
fricklerhandwerk added a commit to fricklerhandwerk/nix.dev that referenced this pull request Nov 7, 2023
this removes a difference to how Nix currently fetches flake references.

using a constant is preferrable because renaming the source won't force
downstream rebuilds of store objects cached from when flakes were used.

upstream fix: nmattia/niv#379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant