-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove flake.nix #761
remove flake.nix #761
Conversation
97a1a23
to
d28c8ae
Compare
Deploy Preview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, just needs a rebase as far as I can see, or is there anything else needed?
I ran into morally unneeded rebuilds that led me to open nmattia/niv#379. That kind of made me back off from the idea for a while. I'll give it another thought when my mind is fresh, rebasing it should be quick. |
@fricklerhandwerk As an alternative, https://github.com/andir/npins do exist too. |
I'd not worry about that, it's an orthogonal concern, let's not get stuck in too many rabbit holes. I'd be willing to merge this if rebased. |
use niv for dependency management. this follows our own tutorials on writing packages and development shells, and we generally find it is easier to read and work with. Co-authored-by: Alejandro Sanchez Medina <[email protected]>
this removes a difference to how Nix currently fetches flake references. using a constant is preferrable because renaming the source won't force downstream rebuilds of store objects cached from when flakes were used. upstream fix: nmattia/niv#379
d28c8ae
to
5337248
Compare
It just occurred to me that we'd totally be breaking the automatic nixos.org updates again, since it depends on |
This is needed for the homepage updates: #792 |
Opened NixOS/nixos-homepage#1148 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-11-27-nix-team-meeting-minutes-107/36112/1 |
use niv for dependency management.
this follows our own tutorials on writing packages and development
shells, and we generally find it is easier to read and work with.
co-authored-by: @alejandrosame