Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove flake.nix #761

Merged
merged 2 commits into from
Nov 7, 2023
Merged

remove flake.nix #761

merged 2 commits into from
Nov 7, 2023

Conversation

fricklerhandwerk
Copy link
Collaborator

use niv for dependency management.

this follows our own tutorials on writing packages and development
shells, and we generally find it is easier to read and work with.

co-authored-by: @alejandrosame

@fricklerhandwerk fricklerhandwerk requested a review from a team as a code owner October 16, 2023 15:13
@fricklerhandwerk fricklerhandwerk marked this pull request as draft October 17, 2023 08:48
@github-actions
Copy link
Contributor

Deploy Preview

Name Result
Last commit: d28c8ae74693b6c5654d2e886291a98a7c4d25fc
Preview URL: https://add128c3.nix-dot-dev.pages.dev

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, just needs a rebase as far as I can see, or is there anything else needed?

@fricklerhandwerk
Copy link
Collaborator Author

I ran into morally unneeded rebuilds that led me to open nmattia/niv#379. That kind of made me back off from the idea for a while. I'll give it another thought when my mind is fresh, rebasing it should be quick.

@RaitoBezarius
Copy link
Member

@fricklerhandwerk As an alternative, https://github.com/andir/npins do exist too.

@infinisil
Copy link
Member

I'd not worry about that, it's an orthogonal concern, let's not get stuck in too many rabbit holes. I'd be willing to merge this if rebased.

fricklerhandwerk and others added 2 commits November 7, 2023 03:04
use niv for dependency management.

this follows our own tutorials on writing packages and development
shells, and we generally find it is easier to read and work with.

Co-authored-by: Alejandro Sanchez Medina <[email protected]>
this removes a difference to how Nix currently fetches flake references.

using a constant is preferrable because renaming the source won't force
downstream rebuilds of store objects cached from when flakes were used.

upstream fix: nmattia/niv#379
@fricklerhandwerk fricklerhandwerk marked this pull request as ready for review November 7, 2023 02:12
@infinisil
Copy link
Member

It just occurred to me that we'd totally be breaking the automatic nixos.org updates again, since it depends on nix.dev being a flake. I think that's okay though, nix.dev doesn't need to be a stable API surface.

@infinisil infinisil merged commit 9114595 into NixOS:master Nov 7, 2023
4 checks passed
@infinisil
Copy link
Member

This is needed for the homepage updates: #792

@infinisil
Copy link
Member

Opened NixOS/nixos-homepage#1148

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-11-27-nix-team-meeting-minutes-107/36112/1

@fricklerhandwerk fricklerhandwerk deleted the remove-flakes branch February 6, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants