We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The client flush method is implemented in terms of stopping and restarting the Transmission:
flush
Transmission
libhoney-rust/src/client.rs
Lines 122 to 133 in 2f7cdc8
Unfortunately, the stop event causes a break that breaks out of the loop and doesn't send any of the queued events:
break
libhoney-rust/src/transmission.rs
Lines 212 to 215 in 62d6da9
I think the code should probably jump to this line instead of breaking out of the loop:
Line 238 in 62d6da9
The text was updated successfully, but these errors were encountered:
Have stop/flush return a Future for callers to wait on
393afce
Resolves nlopes#66 and fixes nlopes#65.
f075125
Successfully merging a pull request may close this issue.
The client
flush
method is implemented in terms of stopping and restarting theTransmission
:libhoney-rust/src/client.rs
Lines 122 to 133 in 2f7cdc8
Unfortunately, the stop event causes a
break
that breaks out of the loop and doesn't send any of the queued events:libhoney-rust/src/transmission.rs
Lines 212 to 215 in 62d6da9
I think the code should probably jump to this line instead of breaking out of the loop:
libhoney-rust/src/transmission.rs
Line 238 in 62d6da9
The text was updated successfully, but these errors were encountered: