Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda Instrumentation #5

Closed
rasviitanen opened this issue Mar 15, 2021 · 2 comments · Fixed by #7
Closed

AWS Lambda Instrumentation #5

rasviitanen opened this issue Mar 15, 2021 · 2 comments · Fixed by #7
Labels
enhancement New feature or request

Comments

@rasviitanen
Copy link
Contributor

rasviitanen commented Mar 15, 2021

We ran into some issues running tracing-honeycomb on AWS lambda.

Basically we experienced two problems:

  1. Lambda functions resolves once it replies to the requestee, so libhoney would need flush its queued events before a response can be sent. This can take a while and lead to poor performance, as flushing libhoney is not instant.
  2. libhoney does not handle flushing of queued events very well (Queued events are ignored when flushing client nlopes/libhoney-rust#65).

Luckily, Honeycomb provides a layer that fixes this: https://docs.honeycomb.io/getting-data-in/integrations/aws/aws-lambda/

To make it work with tracing-honeycomb, it would need to send its spans to stdout instead of a libhoney client.


We have been working on a fix that makes the HoneycombTelemetry generic over some Reporter, where you can pick either Stdout/Libhoney via a builder.

Is this something you would like to see added to this repository?
We would be happy to add our implementation if so.

@Fishrock123 Fishrock123 added the enhancement New feature or request label Mar 19, 2021
@Fishrock123
Copy link
Contributor

Yes please. We'd like to run rust lambdas in the near future as well and this would be very much appreciated!

@Fishrock123
Copy link
Contributor

Released in 0.4.1: https://github.com/eaze/tracing-honeycomb/releases/tag/tracing-honeycomb-0.4.1

(I yanked 0.4.0 due to the wrong git commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants