Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/Alert #640

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Refactor/Alert #640

merged 8 commits into from
Sep 18, 2024

Conversation

AdhamAH
Copy link
Member

@AdhamAH AdhamAH commented Sep 16, 2024

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rijkshuisstijl-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:15am
rijkshuisstijl-community-templates ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:15am
rvs-rivm-nl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:15am

packages/components-css/alert/index.scss Outdated Show resolved Hide resolved
packages/components-react/src/Alert.test.tsx Outdated Show resolved Hide resolved
packages/components-react/src/Alert.tsx Outdated Show resolved Hide resolved
packages/storybook/src/community/alert.stories.tsx Outdated Show resolved Hide resolved
@Rozerinay
Copy link
Contributor

Design review 2

Super! Ik zie dat de heading en de grootte van het icoon zijn opgelost.

We kunnen de headingLevel niet meer aanpassen, toch? In dat geval zou ik deze optie uit het overzicht verwijderen.

image

@AdhamAH AdhamAH merged commit df49bac into main Sep 18, 2024
12 checks passed
@AdhamAH AdhamAH deleted the refactor/alert branch September 18, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants