Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert #472

Closed
Robbert opened this issue Jul 31, 2024 · 2 comments · Fixed by #517
Closed

Alert #472

Robbert opened this issue Jul 31, 2024 · 2 comments · Fixed by #517
Assignees
@AdhamAH @Rozerinay

Comments

@Robbert
Copy link
Member

Robbert commented Jul 31, 2024 •
edited by Rozerinay
Loading

Dit is gewoon een Alert

Figma
Alert in NLDS - Rijksoverheid - Bibliotheek
@Robbert Robbert converted this from a draft issue Jul 31, 2024
@Rozerinay
Copy link
Contributor

PR: #511

@AdhamAH AdhamAH mentioned this issue Aug 7, 2024
Merged
MeesD94 pushed a commit that referenced this issue Aug 22, 2024
@AdhamAH
Feature/alert (#517)
c2ada1b 
closes #472 
Alert Component
@AlineNap AlineNap self-assigned this Sep 3, 2024
@Rozerinay Rozerinay assigned Rozerinay and unassigned AlineNap Sep 3, 2024
@Rozerinay
Copy link
Contributor

Design review

  • Voor de Heading is rhc.font-size.heading.level-3 gebruikt, in plaats van rhc.font-size.heading.level-5.
  • Ik zie overigens dat je kunt switchen in het heading level. Waarom maken we dit mogelijk?
  • Bij het versmallen van de viewport, schaalt de icoon mee. Die wordt erg klein. Dit hoort een fixed size te hebben.

@Rozerinay Rozerinay changed the title Invalid form alert Alert Sep 12, 2024
@AdhamAH AdhamAH mentioned this issue Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdhamAH AdhamAH

@Rozerinay Rozerinay

Labels
None yet
Projects
Community Sprint - Rijkshuisstijl componenten
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/alert nl-design-system/rijkshuisstijl-community
4 participants
@Robbert @AdhamAH @AlineNap @Rozerinay