Stop reexporting Errno variants
#696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Susurrus
suggested changes
Jul 25, 2017
| } | ||
|
|
||
| /// Create a new invalid argument error (`EINVAL`) | ||
| pub fn invalid_argument() -> Error { | ||
| Error::Sys(errno::EINVAL) | ||
| Error::Sys(Errno::EINVAL) |
There was a problem hiding this comment.
I'm not certain that I like Errno::EINVAL and Errno::last(). I don't think it makes sense for last() to be in the same place in the heirarchy as EINVAL.
There was a problem hiding this comment.
Are you sure about that? This is definitely the most "rustic" way to do it.
|
This still actually has Errno visible from the root when I think it should stay within |
|
LGTM. @asomers You want to give this a lookover at all? |
Susurrus
approved these changes
Dec 4, 2017
|
@jonas-schievink if you could squash this into a single commit, I'll go ahead and merge this. Thanks! |
cc #664 (unsure if this is everything needed)
|
Perfect, thanks @jonas-schievink! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #664 (unsure if this is everything needed)