Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errnos are available through multiple paths in nix #664

Closed
Susurrus opened this issue Jul 9, 2017 · 3 comments
Closed

Errnos are available through multiple paths in nix #664

Susurrus opened this issue Jul 9, 2017 · 3 comments

Comments

@Susurrus
Copy link
Contributor

Susurrus commented Jul 9, 2017

The current problem is the errnos (like EAGAIN) are exposed at nix::Errno::EAGAIN and nix::errno::EAGAIN. We should choose one "right" path and only expose these constants there. I'd probably keep Errno at nix::errno::Errno instead of re-exporting it in the root.

@jonas-schievink
Copy link
Contributor

AFAIK reexporting enum variants is considered bad style (they're scoped for a reason)

@Susurrus
Copy link
Contributor Author

Indeed. Would you be interested in taking this on and filing a PR to get this all cleaned up? I started working on this but the errno module needs more work than I realized.

@jonas-schievink
Copy link
Contributor

I'm currently taking a look at #586, but after that's finished I can check this one out.

@Susurrus Susurrus added this to the 1.0 milestone Nov 8, 2017
bors bot added a commit that referenced this issue Dec 5, 2017
696: Stop reexporting `Errno` variants r=Susurrus a=jonas-schievink

Closes #664 (unsure if this is everything needed)
@bors bors bot closed this as completed in #696 Dec 5, 2017
Susurrus pushed a commit to Susurrus/nix that referenced this issue Dec 6, 2017
cc nix-rust#664 (unsure if this is everything needed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants