Rename EventFlag to EvFlag and FilterFlag to NoteFlag
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Palash Nigam <[email protected]>
asomers
requested changes
Oct 7, 2019
|
Hi @asomers should the changelog entry go in the unreleased section or a specific version? And should it be in a separate commit or should I amend this commit? |
|
The unreleased section, of course. And you can combine it with the same commit that changes the code. |
|
i found this while cleaning up my notifications, not sure how i missed this for so long, apologies for the inactivity, I am closing this so that someone else can work on the issue. thanks for the reviews and once again sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first rust PR 😄
Related to: #317