-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flag type names to match FOO_* => FooFlags convention #317
Labels
Milestone
Comments
I guess this can be closed as #1024 is merged? |
Some of the other types haven't been changed yet, though. |
@asomers oh let me see which ones. Sorry I missed those. If you can point me to some other, I'd be glad to change those as well. It will give me some way to peruse through the source. |
vdagonneau
pushed a commit
to vdagonneau/nix
that referenced
this issue
Feb 20, 2019
Most of the EventFlags have been renamed already, but Poll was the only one remaining. This commit fixes that. Issue 317 nix-rust#317
Hi 👋 I made a PR for |
howjmay
added a commit
to howjmay/nix
that referenced
this issue
Aug 29, 2024
relates to nix-rust#317
3 tasks
howjmay
added a commit
to howjmay/nix
that referenced
this issue
Oct 1, 2024
relates to nix-rust#317
howjmay
added a commit
to howjmay/nix
that referenced
this issue
Oct 1, 2024
relates to nix-rust#317
howjmay
added a commit
to howjmay/nix
that referenced
this issue
Oct 1, 2024
relates to nix-rust#317
howjmay
added a commit
to howjmay/nix
that referenced
this issue
Oct 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The convention was added in #287, and there are a few places that need changing. I'm going through all the bitflags as part of #315, and noticing them. Here's a (partial) list:
poll::EventFlags
=>PollFlags
(1)sys::epoll::EpollEventKind
=>EpollFlags
(1)sys::event::EventFlag
=>EvFlags
sys::event::FilterFlag
=>NoteFlags
sys::eventfd::EventFdFlag
=>EFdFlags
sys::memfd::MemFdCreateFlag
=>MFdFlags
sys::quota::QuotaValidFlags
=>QIFFlags
(unsure about capitalization)sys::stat::{SFlag, Mode}
=>SFlags
? (2)sys::statvfs::FsFlags
=> usesys::mount::MsFlags
? (3)sys::termios::{InputFlags, OutputFlags, ControlFlags, LocalFlags}
=> ? (4)(1) these might need amending the convention. The flags are named
POLLIN
,POLLOUT
,EPOLLIN
,EPOLLOUT
, etc: there is no underscore(2) these are used in different parameters; needs to looked at a bit more carefully
(3) man page for
statvfs(2)
says(4) These flags have no common prefix.
The text was updated successfully, but these errors were encountered: