nixos: add sharedModules and extraSpecialArgs options #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagokokada
approved these changes
Feb 10, 2021
|
BTW, maybe we could add something similar to nix-darwin so we can finally close issue #1698. |
7 tasks
|
It looks like half of this PR is already done at #1757 so I can remove my extraModules option if that one gets merged. |
|
I copied over the changes to the nix-darwin module too along with the nixosConfig specialArg. |
|
@rycee @berbiche Could we have this PR reviewed? It makes some use cases in HM with Flakes much easier. I am using this PR in my backported version HM with great success (well, at least the |
berbiche
requested changes
Feb 15, 2021
Pacman99
force-pushed
the
more-extras
branch
2 times, most recently
from
c222091 to
672b92b
Compare
|
@berbiche Thanks for the review! fixed and rebased.
I'm glad it works! I think the extraSpecialArgs is more useful for me too. I find the extra modules useful to prevent repeating code for multiple users. And I want it for nixflk, so we can automatically wire private modules. |
berbiche
requested changes
Feb 15, 2021
Pacman99
force-pushed
the
more-extras
branch
from
d2a7f11 to
ca01e72
Compare
|
Cool fixed that. |
berbiche
reviewed
Feb 17, 2021
Co-authored-by: Nicolas Berbiche <[email protected]>
Pacman99
force-pushed
the
more-extras
branch
from
ca01e72 to
b1c3ee8
Compare
Pacman99
changed the title
|
The Edit: Otherwise it looks fine to me, thanks for the contribution! |
rycee
reviewed
Feb 18, 2021
Pacman99
force-pushed
the
more-extras
branch
from
b1c3ee8 to
3d36a55
Compare
berbiche
approved these changes
Feb 18, 2021
thiagokokada
pushed a commit
to thiagokokada/home-manager
that referenced
this pull request
Feb 23, 2021
…munity#1793) This allows users of the nixos and nix-darwin module to set shared modules for all users and extra specialArgs to be available to home-manager modules. The latter is named extraSpecialArgs just like the argument to modules/default.nix. This could be confusing since the the two are independent in code, but they do mean the same thing so I think the name fits. Darwin can now refer to the global system configuration if used as a module through the special `darwinConfig` argument. Co-authored-by: Nicolas Berbiche <[email protected]>
thiagokokada
pushed a commit
to thiagokokada/home-manager
that referenced
this pull request
Feb 23, 2021
…munity#1793) This allows users of the nixos and nix-darwin module to set shared modules for all users and extra specialArgs to be available to home-manager modules. The latter is named extraSpecialArgs just like the argument to modules/default.nix. This could be confusing since the the two are independent in code, but they do mean the same thing so I think the name fits. Darwin can now refer to the global system configuration if used as a module through the special `darwinConfig` argument. Co-authored-by: Nicolas Berbiche <[email protected]>
malte-v
pushed a commit
to malte-v/home-manager
that referenced
this pull request
Feb 24, 2021
…munity#1793) This allows users of the nixos and nix-darwin module to set shared modules for all users and extra specialArgs to be available to home-manager modules. The latter is named extraSpecialArgs just like the argument to modules/default.nix. This could be confusing since the the two are independent in code, but they do mean the same thing so I think the name fits. Darwin can now refer to the global system configuration if used as a module through the special `darwinConfig` argument. Co-authored-by: Nicolas Berbiche <[email protected]>
aakropotkin
pushed a commit
to aakropotkin/home-manager
that referenced
this pull request
Feb 28, 2021
…munity#1793) This allows users of the nixos and nix-darwin module to set shared modules for all users and extra specialArgs to be available to home-manager modules. The latter is named extraSpecialArgs just like the argument to modules/default.nix. This could be confusing since the the two are independent in code, but they do mean the same thing so I think the name fits. Darwin can now refer to the global system configuration if used as a module through the special `darwinConfig` argument. Co-authored-by: Nicolas Berbiche <[email protected]>
5 tasks
bors bot
added a commit
to divnix/digga
that referenced
this pull request
Mar 23, 2021
156: Improve Home Manager support: profiles/suites, modules, extern, flake outputs r=Pacman99 a=Pacman99 A really simple method of implementing #119. This relies on a feature that I added in home-manager master for module options of extraSpecialArgs and sharedModules, nix-community/home-manager#1793. I could try and get that backported to 20.09. But I thought I'd get some feedback on these changes first. Co-authored-by: Pacman99 <[email protected]>
cab404
pushed a commit
to cab404/home-manager
that referenced
this pull request
Apr 23, 2021
…munity#1793) This allows users of the nixos and nix-darwin module to set shared modules for all users and extra specialArgs to be available to home-manager modules. The latter is named extraSpecialArgs just like the argument to modules/default.nix. This could be confusing since the the two are independent in code, but they do mean the same thing so I think the name fits. Darwin can now refer to the global system configuration if used as a module through the special `darwinConfig` argument. Co-authored-by: Nicolas Berbiche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1698
This allows users of the nixos and nix-darwin module to set shared modules for all users and extra specialArgs to be available to home-manager modules.
The latter is named extraSpecialArgs just like the argument to modules/default.nix. This could be confusing since the the two are independent in code, but they do mean the same thing so I think the name fits.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.