-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option home-manager.sharedModules #1757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff-wise LGTM.
Please fix the commit message: https://github.com/nix-community/home-manager/blob/master/doc/contributing.adoc#sec-commit-style
Thanks for the contribution! |
Right, yeah then it should be sufficient with the description change.
Nicolas Berbiche <[email protected]> writes:
… @berbiche commented on this pull request.
> @@ -65,6 +66,15 @@ in {
'';
};
+ sharedModules = mkOption {
+ type = types.listOf types.anything;
It used to be a `types.path` but I asked for a change because you then cannot use functions.
The verification will be done either way by the module system.
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#1757 (comment)
|
This option is a list of modules shared among all users to avoid importing the same modules for every user manually.
I didn't see this before I submitted a similar PR, #1793, which also adds extraSpecialArgs as an option. So I could remove the extraModules portion of that PR. |
Description
This option is for modules shared among all users to avoid having to import all the same modules on every user
I've tested with a module that adds an option and if enabled add an extra package using
writeShellScriptBin
.Also tested using nixos-option if the option appears too if I create another user
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS
.