Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option home-manager.sharedModules #1757

Closed
wants to merge 1 commit into from

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Jan 29, 2021

Description

This option is for modules shared among all users to avoid having to import all the same modules on every user

I've tested with a module that adds an option and if enabled add an extra package using writeShellScriptBin.

Also tested using nixos-option if the option appears too if I create another user

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@lucasew lucasew requested a review from rycee as a code owner January 29, 2021 15:47
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixos/default.nix Outdated Show resolved Hide resolved
nixos/default.nix Outdated Show resolved Hide resolved
@berbiche
Copy link
Member

Thanks for the contribution!

nixos/default.nix Outdated Show resolved Hide resolved
nixos/default.nix Outdated Show resolved Hide resolved
@rycee
Copy link
Member

rycee commented Feb 5, 2021 via email

This option is a list of modules shared among all users to avoid
importing the same modules for every user manually.
@Pacman99
Copy link
Contributor

I didn't see this before I submitted a similar PR, #1793, which also adds extraSpecialArgs as an option. So I could remove the extraModules portion of that PR.

@berbiche
Copy link
Member

Thanks again for the contribution @lucasew.
I will be closing this since #1793 was merged.

@berbiche berbiche closed this Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants