-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow GIFs in reports #128
Conversation
I also wanted to double-check that raising an exception for unsupported extensions (which I added in #126) made sense: nireports/nireports/assembler/reportlet.py Lines 295 to 296 in dc54385
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maint/23.2.x #128 +/- ##
================================================
- Coverage 56.46% 56.26% -0.20%
================================================
Files 20 20
Lines 2019 2019
Branches 319 319
================================================
- Hits 1140 1136 -4
- Misses 798 802 +4
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mattcieslak and I are bumping into this in QSIPrep. @effigies would you be willing to make a new release? 23.2.3 or 24.0.3? |
Yes, I'm working on a release cascade. Started with nitransforms, moving onto nipype, and then nireports and niworkflows, and so on. |
Awesome! |
I went ahead and released 24.0.3. |
Related to #124.
Changes proposed:
.gif
to the list of valid extensions.