Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GIFs in reports #128

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Allow GIFs in reports #128

merged 1 commit into from
Oct 4, 2024

Conversation

tsalo
Copy link
Contributor

@tsalo tsalo commented Aug 23, 2024

Related to #124.

Changes proposed:

  • Add .gif to the list of valid extensions.

@tsalo
Copy link
Contributor Author

tsalo commented Aug 23, 2024

I also wanted to double-check that raising an exception for unsupported extensions (which I added in #126) made sense:

else:
raise RuntimeError(f"Unsupported file extension: {ext}")

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.26%. Comparing base (5358759) to head (d7e2576).
Report is 4 commits behind head on maint/23.2.x.

Files with missing lines Patch % Lines
nireports/assembler/reportlet.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           maint/23.2.x     #128      +/-   ##
================================================
- Coverage         56.46%   56.26%   -0.20%     
================================================
  Files                20       20              
  Lines              2019     2019              
  Branches            319      319              
================================================
- Hits               1140     1136       -4     
- Misses              798      802       +4     
  Partials             81       81              
Flag Coverage Δ
unittests 56.26% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 13d2d0f into nipreps:maint/23.2.x Oct 4, 2024
19 of 21 checks passed
@tsalo tsalo deleted the add-gifs branch November 17, 2024 14:51
@tsalo
Copy link
Contributor Author

tsalo commented Nov 18, 2024

@mattcieslak and I are bumping into this in QSIPrep. @effigies would you be willing to make a new release? 23.2.3 or 24.0.3?

@effigies
Copy link
Member

Yes, I'm working on a release cascade. Started with nitransforms, moving onto nipype, and then nireports and niworkflows, and so on.

@tsalo
Copy link
Contributor Author

tsalo commented Nov 18, 2024

Awesome!

@effigies
Copy link
Member

I went ahead and released 24.0.3.

effigies added a commit that referenced this pull request Nov 22, 2024
24.0.3 (November 18, 2024)

Bug-fix release in the 24.0.x series.

Loosens constraints on report generation to permit GIFs.
Technically a feature, but the impact on existing code is null.

CHANGES
-------

* ENH: Allow GIFs in reports by @tsalo in #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants