Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PNG and JPEG figures in reports #124

Closed
tsalo opened this issue Aug 16, 2024 · 3 comments · Fixed by #126
Closed

Support PNG and JPEG figures in reports #124

tsalo opened this issue Aug 16, 2024 · 3 comments · Fixed by #126
Labels
enhancement New feature or request

Comments

@tsalo
Copy link
Contributor

tsalo commented Aug 16, 2024

What would you like to see added in this software?

With 23.2.1, it doesn't look like PNG figures are collected by Nireports, even when I specify the extension field as .png or png. If possible, it would be great to support these figures, as QSIRecon has some figures that it can't save as SVGs.

Do you have any interest in helping implement the feature?

Yes

Additional information / screenshots

No response

@effigies
Copy link
Member

Agreed. nireports should be general, even if most nipreps exclusively use HTML and SVG.

@mattcieslak
Copy link

Thank you @tsalo for putting this together! This would be a big deal for dMRI reports because a lot of them are rasterized 3d renderings from FURY. Instead of embedding them in svgs, it would be very convenient just to send them to the reports directly.

@tsalo
Copy link
Contributor Author

tsalo commented Aug 23, 2024

I think we could close this, but one thing @mattcieslak and I realized after I merged #126 is that I forgot about GIFs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants