ENH: Outsource data filtering from estimator into its own module #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
force-pushed
the
enh/start-filtering-module
branch
from
e02f5e0
to
d6bfd69
Compare
effigies
previously approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Looks good. I don't understand the sphinx warning:
The sphinx warning seems to be sphinx-doc/sphinx#8088, which was fixed by sphinx-doc/sphinx#8095.
Didn't dig much, I could be way off on that.
jhlegarreta
reviewed
Jun 11, 2024
| ---------- | ||
| data : :obj:`~numpy.ndarray` | ||
| The input n-dimensional data array. | ||
| p_min : :obj:`float`, optional (default=35) |
There was a problem hiding this comment.
I would not put the defaults in the docstrings: if for whatever reason they are changed in the method signature, there is a risk of not updating the docstrings. I've seen this happen in other projects, frequently.
There was a problem hiding this comment.
Yes, sounds reasonable. Please patch away :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of #116 sequels.