-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a setting to enable / disable the numpy type preprocessor #8095
Conversation
@tk0miya, I think the only issues left are the naming and the default value. I'm not sure about both, but I guess making the preprocessor opt-in would make the migration smoother. |
+1 for the naming. Let's go with this. About the default value, I'm still debating. It might be better to make disabled it by default if many projects uses types like type-hints. And it will be enabled after we'll support them in the future release. But I don't know how many projects do that. What do you think? |
I don't know how many projects are using type hints instead of numpydoc type specs, either, and the projects I'm working on seem to consider type hints less readable than the type specs, but I agree that it might be better to make the type preprocessor opt-in for now. That way people can decide when they want to migrate (since version pinning does not always work, and people might also want some other new feature first). |
I changed the default to Edit: would you consider this a breaking change? |
Thank you for your update. I don't think this is a breaking change. The numpy type spec has been just released last week. So this does not harm anybody, I believe. Let's enable it after enough matured. |
Feature or Bugfix
Purpose
This adds the
napoleon_preprocess_types
setting (could also benapoleon_preprocess_numpy_types
ornapoleon_link_types
/napoleon_link_numpy_types
) that controls whether the preprocessor is run. Defaults toTrue
for now.Relates