Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make many gun_http2 functions return state or error tuple #301

Closed
wants to merge 6 commits into from
Closed

Make many gun_http2 functions return state or error tuple #301

wants to merge 6 commits into from

Commits on Sep 27, 2022

  1. Make many gun_http2 functions return state or error tuple 

    The following functions used to return a state, but now return {state, State}
or {error, Reason}:

* frame/5
* update_window/1,2
* maybe_ack_or_notify/2
* reset_stream/3
* push_promise_frame/7
* goaway/2
* maybe_send_data/6
* send_data/4
* send_data/6
* send_data_frame/4
    @zuiderkwast
    zuiderkwast committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    6679d68 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Address code review comments

    @zuiderkwast
    zuiderkwast committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    447c17c View commit details
    Browse the repository at this point in the history

  2. Delete stream regardless of error in data_frame1

    @zuiderkwast
    zuiderkwast committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    6b2b655 View commit details
    Browse the repository at this point in the history

  3. Revert "Delete stream regardless of error in data_frame1" 

    This reverts commit 6b2b655.
    @zuiderkwast
    zuiderkwast committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    f160e0a View commit details
    Browse the repository at this point in the history

  4. Add todo for returning new state and error in data_frame1

    @zuiderkwast
    zuiderkwast committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    3fa1f75 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Fix a return error tuple in parse/5

    @zuiderkwast
    zuiderkwast committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    0b6915e View commit details
    Browse the repository at this point in the history