Make many gun_http2 functions return state or error tuple #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following functions used to return a state, but now return {state, State}
or {error, Reason}:
* frame/5
* update_window/1,2
* maybe_ack_or_notify/2
* reset_stream/3
* push_promise_frame/7
* goaway/2
* maybe_send_data/6
* send_data/4
* send_data/6
* send_data_frame/4
|
Good morning Loïc. Are you busy? I believe when this is merged, the remaining "handle send errors" will be a very small change. |
|
Sounds good. Yes if I don't get to this today it will be next Monday. |
|
OK, great. The change is large but trivial, so I hope it is easy to review. Then, I can help finishing the remaining 2.0 projects, if you know what you want with them. :-) |
essen
reviewed
Oct 10, 2022
essen
reviewed
Oct 10, 2022
essen
reviewed
Oct 10, 2022
essen
reviewed
Oct 10, 2022
|
@zuiderkwast Reviewed. There's at least one error and a couple consistency problems that should easily be resolved. |
|
Merged, thanks! I've also fixed the TLS tests that fail. Dialyzer will fail until the other PR is merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following functions used to return a state, but now return {state, State} or {error, Reason}:
This is incremental refactoring preparing for #243