+ show an error notification if, during nimlangserver version detection, the #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, the
nimlangserver process terminates with an error. Include the stdout and stderr
output in the error notification. This shows errors, such as missing .so files
to the user like this:
Error starting nimlangserver: could not load: lipcre.so(.3|1)
(compile with -d:nimDebugDlOpen for more information)
Previously, these errors would not be shown to the user, and instead a
spurious and misleading "There is a new Nim langserver version available"
message would be shown. The actual error would be well hidden under the
"Nim Language Server" tab in the Output window, which is not normally shown,
unless the user specifically opens this window.
|
Before: |
|
This is a great change, starting at nim-lang/Nim@09580ee NimSuggest will also throw an error if any on init (need to backport it). We can use this same mechanism to inform the user. |
jmgomez
pushed a commit
to jmgomez/vscode-nim
that referenced
this pull request
Mar 26, 2024
…on, the (nim-lang#44) nimlangserver process terminates with an error. Include the stdout and stderr output in the error notification. This shows errors, such as missing .so files to the user like this: Error starting nimlangserver: could not load: lipcre.so(.3|1) (compile with -d:nimDebugDlOpen for more information) Previously, these errors would not be shown to the user, and instead a spurious and misleading "There is a new Nim langserver version available" message would be shown. The actual error would be well hidden under the "Nim Language Server" tab in the Output window, which is not normally shown, unless the user specifically opens this window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nimlangserver process terminates with an error. Include the stdout and stderr
output in the error notification. This shows errors, such as missing .so files
to the user like this:
Error starting nimlangserver: could not load: lipcre.so(.3|1)
(compile with -d:nimDebugDlOpen for more information)
Previously, these errors would not be shown to the user, and instead a
spurious and misleading "There is a new Nim langserver version available"
message would be shown. The actual error would be well hidden under the
"Nim Language Server" tab in the Output window, which is not normally shown,
unless the user specifically opens this window.