Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Check if libpcre.so library is installed during nimlangserver installation #187

Closed
aboisvert opened this issue Feb 23, 2024 · 3 comments

Comments

@aboisvert
Copy link

It would be a better experience if there was a dependency check for libpcre.so library during nimlangserver installation otherwise it can lead to errors later on.

This issue relates to #84 as well as as nim-lang/vscode-nim#43.

In the case of vscode, it can lead to mysterious/silent failure which is not obvious to diagnose since one isn't expected to run nimlangserver on its own and therefore the error could not load: libpcre.so(.3|.1|) is never shown directly to the user and the VSCode plugin just mysteriously fails activation.

@nickysn
Copy link
Collaborator

nickysn commented Feb 23, 2024

I've also opened a PR in the VS code extension, so the error message is shown:
nim-lang/vscode-nim#44
Of course, we can also add dependency checks to the nimble file as well. Or do other things to ensure the dependencies are installed as well.

@arnetheduck
Copy link
Contributor

Why not get rid of the pcre dependency instead? ie with https://github.com/nitely/nim-regex

@jmgomez
Copy link
Collaborator

jmgomez commented Oct 30, 2024

Fixed by #259

@jmgomez jmgomez closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants