Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring back argparse #16242

Merged
merged 1 commit into from
Dec 5, 2020
Merged

bring back argparse #16242

merged 1 commit into from
Dec 5, 2020

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Dec 3, 2020 •
edited
Loading

ref #15987

with commit

commit c731f7ab149a539782b0b000853ecef058bc3dde (upstream/devel)
Author: Timothee Cour <[email protected]>
Date:   Thu Dec 3 07:55:43 2020 -0800

    fixes #15939, fixes #15464, fixes #16169, fixes #16226 VM now supports `addr(mystring[ind])` (index + index assignment) (#15987)

@ringabout ringabout closed this Dec 3, 2020
@ringabout ringabout reopened this Dec 3, 2020
@narimiran narimiran added the merge_when_passes_CI mergeable once green label Dec 3, 2020
@ringabout ringabout closed this Dec 4, 2020
@ringabout ringabout reopened this Dec 4, 2020
@timotheecour timotheecour mentioned this pull request Dec 4, 2020
Closed
@timotheecour
Copy link
Member

@xflywind close+reopen is wasteful of CI resources because it restarts all CI, even the ones that succeeded; instead, see this guide I added https://nim-lang.github.io/Nim/contributing.html#the-git-stuff-debugging-ci-failures-flaky-tests-etc to restart just what fails (improvements to this guide welcome).

the CI failures are caused by these 2 regressions:

@timotheecour timotheecour merged commit 70d4df0 into nim-lang:devel Dec 5, 2020
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
@ringabout @mildred
bring back argparse (nim-lang#16242)
af4d3ca
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@ringabout @ardek66
bring back argparse (nim-lang#16242)
947c718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheecour timotheecour timotheecour approved these changes

Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ringabout @timotheecour @narimiran