fix #15939 #15464 #16169 #16226 VM now supports addr(mystring[ind]) (index + index assignment)
#15987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_fix_15939_vm_string_index
branch
2 times, most recently
from
e6e8204 to
3e9c95c
Compare
timotheecour
force-pushed
the
pr_fix_15939_vm_string_index
branch
from
b00da28 to
1654ed0
Compare
timotheecour
changed the title
addr(mystring[ind]) (index + index assignment)addr(mystring[ind]) (index + index assignment)
…[ind])` (index + index assignment), var char return etc
timotheecour
force-pushed
the
pr_fix_15939_vm_string_index
branch
from
6e0e6c4 to
6a8b0f2
Compare
timotheecour
changed the title
addr(mystring[ind]) (index + index assignment)addr(mystring[ind]) (index + index assignment)
Araq
reviewed
Nov 28, 2020
timotheecour
changed the title
addr(mystring[ind]) (index + index assignment)addr(mystring[ind]) (index + index assignment)
Merged
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
nim-lang#16226 VM now supports `addr(mystring[ind])` (index + index assignment) (nim-lang#15987) * fix nim-lang#15939, fix nim-lang#15464 VM now supports `addr(mystring[ind])` (index + index assignment), var char return etc * cleanups * cstring tests * add test for bug nim-lang#15464 * improve test coverage
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
nim-lang#16226 VM now supports `addr(mystring[ind])` (index + index assignment) (nim-lang#15987) * fix nim-lang#15939, fix nim-lang#15464 VM now supports `addr(mystring[ind])` (index + index assignment), var char return etc * cleanups * cstring tests * add test for bug nim-lang#15464 * improve test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15464
fix #15939
fix #16169
fix #16226
see test: tests/misc/taddr.nim
future work after this is merged: