Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler json dump inserts invalid json character at end of output #17853

Closed
jyapayne opened this issue Apr 25, 2021 · 1 comment · Fixed by #17887
Closed

Compiler json dump inserts invalid json character at end of output #17853

jyapayne opened this issue Apr 25, 2021 · 1 comment · Fixed by #17887

Comments

@jyapayne
Copy link
Contributor

This is causing the nim vim plugin to throw an error every time a Nim file is opened.

Example

# x.nim
echo "Hello World!"
# Compile with `nim --dump.format:json --verbosity:0 dump x.nim > out.json`

Current Output

Screen Shot 2021-04-25 at 5 22 31 PM

Expected Output

Screen Shot 2021-04-25 at 5 24 06 PM

Possible Solution

Seems to be something from this PR after investigating using git bisect.

Nim Compiler Version 1.5.1 [MacOSX: arm64]
Compiled at 2021-04-25
Copyright (c) 2006-2021 by Andreas Rumpf

git hash: 9e6f2d7d186f760d8eb7dc26c863f23bd044b9c9
active boot switches: -d:release
@timotheecour
Copy link
Member

I was going to report the same issue:
nim dump --dump.format:json . | jq -r .nimExe now fails after that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants