-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unit separator #17730
Merged
Merged
unit separator #17730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecisely by the tooling
Clyybber
reviewed
Apr 20, 2021
c-blake
added a commit
to c-blake/cligen
that referenced
this pull request
Apr 22, 2021
Closed
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* use the ASCII Unit Separator so that error messages can be handled precisely by the tooling * updated testament
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the Nim compiler uses the ASCII unit separator before a newline for every end of any kind of message. This is simpler than JSON output, mostly backwards compatible and allows tools to know precisely when one error message starts and the other ends.