Add --when-visible (focus|swap) option to the summon-workspace command
#681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and. What should happen when the summoned workspace is visible on another monitor? This option introduces a choice to either: - `focus` the monitor on which the target workspace is already visible (the current behavior) - `swap` the workspaces between the monitors, so that the summoned workspace appears on the focused monitor. The default is `focus`, for backwards compatibility. Ref: nikitabobko#603
lynaghk
force-pushed
the
summon-workspace-action
branch
from
4148543 to
56734b2
Compare
|
I've been driving this today and have noticed a bug: I have enabled and when I summon a workspace the mouse jumps to the other monitor. I'll investigate and see if I can push up a fix. |
|
@lynaghk: I also implemented a similar summon workspace feature - #606 - see the discussion for some of the nuances to keep in mind. the reference to renaming workspaces was for a separate feature idea: xmonad supports swap workspaces on monitors. your other PR (#682) is similar to another PR i implemented (#605), so it looks like we have been thinking similarly 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, let me say AeroSpace is really cool! I've been trying to relive my XMonad memories on Mac for years and am excited about the possibilities with AeroSpace.
This PR implements the swapping behavior discussed in #603.
I could be misunderstanding the AeroSpace internals, but it doesn't seem like this feature is blocking on workspace renaming. I've tested it locally with multiple monitors and tiling / accordion layouts and it seemed to work as intended. (Note: I have not attempted to wire up any automated tests, though would be happy to do so if you'd like me to.)
Even though in that issue you said you wanted
swapto be the default behavior, in the PR I havefocusas the default for backwards compatibility.Finally, I live and work in Oud-West, so if you would prefer to discuss in person --- beverages are on me =D