Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft][focus] add prev and next as directions to focusCommand #605

Closed
wants to merge 1 commit into from
Closed

[draft][focus] add prev and next as directions to focusCommand #605

wants to merge 1 commit into from

Conversation

raisjn
Copy link

@raisjn raisjn commented Oct 20, 2024

Description

Adds prev and next as directions to focus command. The specific benefit here is that they don't rely on cardinal directions and that they wrap around when they get to the first or last window.

This is similar to how xmonad's window cycling feature behaves

Test Plan

  • Load a workspace with multiple windows, verify next and prev cycle between them and don't stop at the end.
    • Verify in accordion and tiles
  • Load a workspace with no windows, verify program doesn't crash

Notes

  • Please edit the commit / commit message as desired
  • I did not regen docs, wasn't able to get it to work properly
  • Please feel free to ignore this commit

@nikitabobko
Copy link
Owner

I appreciate the effort, but the PR doesn't meet the desired quality bar

@nikitabobko nikitabobko added the pr-rejected Pull Request is rejected label Oct 21, 2024
@raisjn raisjn changed the title [focus] add prev and next as directions to focusCommand [draft][focus] add prev and next as directions to focusCommand Oct 21, 2024
@raisjn
Copy link
Author

raisjn commented Oct 21, 2024

no problem, thanks for looking!

@b11e
Copy link

b11e commented Nov 30, 2024

Bump, I was just trying to find this feature as I forget all the time whether i need to focus left or right when stacked.

Is this being tracked elsewhere?

@jakeswenson
Copy link

I appreciate the effort, but the PR doesn't meet the desired quality bar

Curious what is missing in the quality of this? documentation updates? tests? How could someone revive it and take it further?

Or is it not a feature that would be accepted?

I personally would love to have this for my setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-rejected Pull Request is rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants