-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon component #22
Icon component #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and functions as expected. I do get this error in the console when I view the page however:
react-dom.development.js:21 Warning: validateDOMNesting(...): <ul> cannot appear as a descendant of <p>.
in ul (created by EmptyBlock)
in p (created by Context.Consumer)
in Styled(p) (created by EmptyBlock)
in div (created by Context.Consumer)
in Styled(div) (created by Spaced)
in Spaced (created by Context.Consumer)
in Styled(Spaced) (created by EmptyBlock)
in div (created by Context.Consumer)
in Styled(div) (created by Spaced)
in Spaced (created by Context.Consumer)
in Styled(Spaced) (created by EmptyBlock)
in div (created by Context.Consumer)
in Styled(div) (created by EmptyBlock)
in EmptyBlock (created by Ref)
in div (created by Context.Consumer)
in Styled(div) (created by Ref)
in Ref (created by Sidebar)
in div (created by Context.Consumer)
in Styled(div) (created by Spaced)
in Spaced (created by Context.Consumer)
in Styled(Spaced) (created by Sidebar)
in div (created by OverlayScrollbarsComponent)
in div (created by OverlayScrollbarsComponent)
in div (created by OverlayScrollbarsComponent)
in div (created by OverlayScrollbarsComponent)
in OverlayScrollbarsComponent
in Unknown (created by Context.Consumer)
in Styled(Component) (created by ScrollArea)
in ScrollArea (created by Context.Consumer)
in Styled(ScrollArea) (created by Sidebar)
in nav (created by Context.Consumer)
in Styled(nav) (created by Sidebar)
in Sidebar
in Unknown (created by ManagerConsumer)
in ManagerConsumer
in Unknown (created by Layout)
in div (created by Context.Consumer)
in Styled(div) (created by Sidebar)
in Sidebar (created by Layout)
in Layout (created by Context.Consumer)
in WithTheme(Layout)
in Unknown
in div (created by Context.Consumer)
in Styled(div)
in Unknown (created by SizeMeRenderer(Component))
in SizeMeReferenceWrapper (created by SizeMeRenderer(Component))
in SizeMeRenderer(Component) (created by SizeMe(Component))
in SizeMe(Component)
in ThemeProvider
in Unknown (created by ManagerConsumer)
in ManagerConsumer (created by Manager)
in EffectOnMount (created by Manager)
in Manager (created by Context.Consumer)
in Location (created by QueryLocation)
in QueryLocation (created by Root)
in LocationProvider (created by Root)
in HelmetProvider (created by Root)
in Root
@mahamzayed Thanks for reporting that. Looks like this is a Storybook issue, and is fixed in newer versions. I would like to upgrade Storybook in another PR but that is low priority right now. |
Description
The purpose of this PR is to add the icon component and documentation.
Type of change
How Has This Been Tested?
Checklist: