Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip/add options app json #749

Closed
wants to merge 15 commits into from
Closed

Wip/add options app json #749

wants to merge 15 commits into from

Conversation

someoneAnyone
Copy link
Contributor

Second try!
Added the following to App.json:

  ,"CUSTOM_TITLE": {
      "description": "Customize the name of the website, usually the name of T1.",
      "value": "",
      "required": false
  },
  "THEME": {
      "description": "Possible values default or colors",
      "value": "",
      "required": false
  },
  "SHOW_RAWBG": {
      "description": "Possible values always, never or noise",
      "value": "",
      "required": false
  }

Issue #748

@codecov-io
Copy link

Current coverage is 83.93%

Merging #749 into dev will not affect coverage as of 04a90c6

@@              dev    #749   diff @@
=====================================
  Files          46      46       
  Stmts        2420    2420       
  Branches      486     486       
  Methods       366     366       
=====================================
  Hit          2031    2031       
  Partial        17      17       
  Missed        372     372       

Review entire Coverage Diff


Uncovered Suggestions

  1. +0.57% via lib/mqtt.js#128...141
  2. +0.49% via lib/utils.js#31...42
  3. +0.49% via lib/mqtt.js#292...303
  4. See 7 more...

Powered by Codecov

@jasoncalabrese
Copy link
Member

Looks like lots of indent changes, project default is 2 spaces

@jasoncalabrese
Copy link
Member

Pulled commits with #751

@someoneAnyone someoneAnyone deleted the wip/add-options-app-json branch September 22, 2015 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants