Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip/add options app json #748

Closed
wants to merge 638 commits into from
Closed

Wip/add options app json #748

wants to merge 638 commits into from

Conversation

someoneAnyone
Copy link
Contributor

Added the following to App.json:

      ,"CUSTOM_TITLE": {
          "description": "Customize the name of the website, usually the name of T1.",
          "value": "",
          "required": false
      },
      "THEME": {
          "description": "Possible values default or colors",
          "value": "",
          "required": false
      },
      "SHOW_RAWBG": {
          "description": "Possible values always, never or noise",
          "value": "",
          "required": false
      }

Issue #712

jasoncalabrese and others added 30 commits July 3, 2015 09:35
fix a bug that caused auto ack'd messaages to be sent over and over
fix order of current raw bg line for raw ar2 predictions
… A bit of a hack, but the alerts are getting very confusing as they're often triggered for no apparent reason on the site visualization.
…calculation using moment.js. Added INFO level warnings. Structural changes suggested by Codacy.
}
}

function buildConfirmText(data) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

Current coverage is 83.67%

Merging #748 into master will increase coverage by +0.50% as of 827a4e7

@@            master    #748   diff @@
======================================
  Files           46      46       
  Stmts         2430    2401    -29
  Branches       486     488     +2
  Methods        380     365    -15
======================================
- Hit           2021    2009    -12
+ Partial         18      17     -1
+ Missed         391     375    -16

Review entire Coverage Diff


Uncovered Suggestions

  1. +0.59% via lib/mqtt.js#128...141
  2. +0.50% via lib/utils.js#31...42
  3. +0.50% via lib/mqtt.js#292...303
  4. See 7 more...

Powered by Codecov

@jasoncalabrese
Copy link
Member

Can you open a new PR targeting dev instead of master

@someoneAnyone
Copy link
Contributor Author

oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants