-
Notifications
You must be signed in to change notification settings - Fork 71.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wip/add options app json #748
Closed
someoneAnyone
wants to merge
638
commits into
nightscout:master
from
someoneAnyone:wip/add-options-app-json
Closed
Wip/add options app json #748
someoneAnyone
wants to merge
638
commits into
nightscout:master
from
someoneAnyone:wip/add-options-app-json
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a bug that caused auto ack'd messaages to be sent over and over
fix order of current raw bg line for raw ar2 predictions
…her doesn't match
… A bit of a hack, but the alerts are getting very confusing as they're often triggered for no apparent reason on the site visualization.
…lean up and refactoring
…calculation using moment.js. Added INFO level warnings. Structural changes suggested by Codacy.
RO translation
…t is truncated with ellipsis
adjust treatment form css so labels have a fixed width
Stupid IE doesn't like function.name
prebolus handling & translation for review
fix issue with windows scrolling the truncated labels for Chrome and IE
} | ||
} | ||
|
||
function buildConfirmText(data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current coverage is
|
Can you open a new PR targeting dev instead of master |
oops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following to App.json:
Issue #712